Summary: | Phabricator: Raw diff reviews & creation of revisions is broken | ||||||
---|---|---|---|---|---|---|---|
Product: | Services | Reporter: | Sean Bruno <sbruno> | ||||
Component: | Code Review | Assignee: | Eitan Adler <eadler> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | araujo, eadler, emaste, gnn, koobs, mat, phabric-admin | ||||
Priority: | --- | Keywords: | needs-qa, regression | ||||
Version: | unspecified | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://reviews.freebsd.org/D2579 | ||||||
Bug Depends on: | 201121 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Sean Bruno
2015-06-25 15:31:04 UTC
Here is a pastebin of what I get on an arc diff --create http://pastebin.com/pM7GpQsR Assign to Eitan as he was/is taking care of this. CC'ing all people who have requested status updates either on IRC or mailing lists to date (that I've seen) The symptoms I am observing are: [user@CURRENT-amd64:/usr/home/koobs/repos/freebsd/ports] arc diff --create devel/pybugz Exception ERR-CONDUIT-CORE: Invalid parameter information was passed to method 'differential.getcommitmessage'. (Run with `--trace` for a full exception trace.) 49% Created attachment 158064 [details]
full `arc diff create` trace
Adding full arc diff --create --trace log
note that creation of diffs and missing diffs are two different issues: (a) creation of diffs: This is due to a bug in cURL: cURL 7.43 has a bug where "Content-Length" is incorrectly cached between requests on the same connection, which breaks the 2nd..Nth request when connections are reused. Recent versions of libphutil work around the issue (the port update is here: https://reviews.freebsd.org/D2894). In the meantime either downgrade cURL to a version earlier than 7.43.0, upgrade cURL to HEAD, or wait for 7.43.1 and upgrade cURL. (b) this was due a big fsck up on my part. I believe I have fixed it (and random testing of various reported broken diffs seems to have confirmed it). Marking the bug resolved due to (b) being resolved and (a) being worked on Re-open until the fix lands in bug 201121, then its resolved The blocking commit was closed. Closing this bug. |