Summary: | [revive port] [patch] lang/haskell-mode.el: readd, stage, and update | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Klaus Aehlig <aehlig> | ||||||
Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | rakuco | ||||||
Priority: | --- | Keywords: | patch, patch-ready | ||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Hi Klaus, Thanks for the patch, sorry that it went unnoticed. A few comments about the new version: - Instead of setting GH_TAGNAME, you could set DISTVERSIONPREFIX=v. - Instead of adding emacs as a build-dependency like that, it makes more sense to set USE_EMACS=yes. You could also drop the bsd.port.options.mk include and use some target helpers instead: post-install-DOCS-on: # documentation installation code Created attachment 168098 [details]
Patch to be applied to latest non-removed lang/haskell-mode.el to stage and update
Ammended patch as suggested; also updated to the latest version
Hi Raphael, Thanks for you comments on my patch, and sorry for answering so late. I amended the patch as suggested; I also updated it to the now latest version of haskell-mode. Please take another look. Thanks, Klaus Thanks, this looks fine. I'll commit a slightly modified version that sets DISTVERSIONSUFFIX earlier, as `portlint -AC' suggests. A commit references this bug: Author: rakuco Date: Sun Mar 13 17:21:22 UTC 2016 New revision: 411004 URL: https://svnweb.freebsd.org/changeset/ports/411004 Log: Readd lang/haskell-mode.el, update to 13.18 and pass maintainership to submitter. PR: 201170 Submitted by: Klaus Aehlig <aehlig@linta.de> Changes: head/lang/Makefile head/lang/haskell-mode.el/ head/lang/haskell-mode.el/Makefile head/lang/haskell-mode.el/distinfo head/lang/haskell-mode.el/files/pkg-message.in Finally landed, thanks a lot for the patch and for sticking around! |
Created attachment 158129 [details] Patch to be applied to latest non-removed lang/haskell-mode.el to stage and update Add lang/haskell-mode.el back to the ports tree, stage it, and update to the latest version. To fix: apply the attached patch to the latest non-removed version of lang/haskell-mode.el