Bug 201313

Summary:	User can leave page with unsubmitted comments
Product:	Services	Reporter:	Warren Block <wblock>
Component:	Code Review	Assignee:	Phabric Admin <phabric-admin>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	emaste
Priority:	---
Version:	unspecified
Hardware:	Any
OS:	Any

Description Warren Block freebsd_committer

2015-07-03 18:51:35 UTC

I entered comments on a review, then apparently forgot to click Submit.  They were still there when I went back to the page on the request of the reviewee, but there was no obvious way of knowing I had not submitted them.  The review was long enough that the "Unsubmitted" label on the comments was off the screen.

A pop-up that appears when trying to leave a page that says "You have unsubmitted comments, submit them before leaving?" would be good.

Phabricator notifies me by email about lots of things, a notice about unsubmitted comments that are more than a few hours old would also be helpful.

Comment 1 Ed Maste freebsd_committer

2015-07-03 19:00:42 UTC

See upstream issue here: https://secure.phabricator.com/T3669

Comment 2 Mathieu Arnold freebsd_committer

2016-05-10 16:10:26 UTC

From the looks of it, this was fixed upstream.

https://secure.phabricator.com/T3669#104089