Bug 201355
| Summary: | [patch] Build failed for multimedia/mpv-0.9.2_1,1 during lib-depends | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan Klymenko <fidaj> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | cjpm, pi | ||||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(cjpm) |
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ivan Klymenko
2015-07-05 11:48:28 UTC
Comment on attachment 158371 [details]
patch-mpv
Thank you :)
Created attachment 158374 [details]
fix ladspa dependency
If DEVELOPER=yes is defined in /etc/make.conf, it stops with this error:
/!\ mpv-0.9.2_2,1: Makefile errors /!\
All LIB_DEPENDS should use the new format and start out with lib. (libfoo.so vs foo.so)
which comes from /usr/ports/Mk/bsd.sanity.mk and
.if defined(LIB_DEPENDS) && ${LIB_DEPENDS:Nlib*}
DEV_ERROR+= "All LIB_DEPENDS should use the new format and start out with lib. \(libfoo.so vs foo.so\)"
.endif
which is probably a problematic cornercase of bsd.sanity.mk.
Expanded, ${LIB_DEPENDS:Nlib*} says:
/usr/local/lib/ladspa/amp.so:/usr/ports/audio/ladspa
This is a case which probably needs to be decided by portmgr@ or by using
a BUILD/RUN_DEPENDS ?
build-tested on 10.1 (i/a) and 9.3a. All OK without DEVELOPER=yes. Created attachment 158380 [details]
fix ladspa dependency
Patch reworked
With the new patch, it fails during configure: Checking for LADSPA plugin support : no You manually enabled the feature 'ladspa', but the autodetection check failed. ===> Script "configure" failed unexpectedly. It needs both a BUILD and a RUN depends... Created attachment 158388 [details]
fix ladspa dependency
- Fix LADSPA dependency
- Bump PORTREVISION
(In reply to Kurt Jaeger from comment #7) Done! (In reply to Carlos Jacobo Puga Medina from comment #9) It's more a LADSPA_BUILD_DEPENDS= ${LOCALBASE}/lib/ladspa/amp.so:${PORTSDIR}/audio/ladspa which builds fine on 10.1(i/a) and 9.3a. So let's do it. A commit references this bug: Author: pi Date: Sun Jul 5 18:53:55 UTC 2015 New revision: 391370 URL: https://svnweb.freebsd.org/changeset/ports/391370 Log: multimedia/mpv: Fix LADSPA dependency, bump PORTREVISION PR: 201355 Reported by: Ivan Klymenko <fidaj@ukr.net> Fix by: Carlos Jacobo Puga Medina <cpm@fbsd.es> (maintainer) Changes: head/multimedia/mpv/Makefile Thanks! |
