Summary: | lots of whines about nvpair* functions in kernel link | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Larry Rosenman <ler> | ||||||
Component: | kern | Assignee: | Mariusz Zaborski <oshogbo> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | Trond.Endrestol, oshogbo, peter, pjd, woodsb02 | ||||||
Priority: | --- | ||||||||
Version: | CURRENT | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Larry Rosenman
![]() ![]() Did you use -DNO_CLEAN option? Did you try to remove /usr/obj/..? This is amd64 architecture? I've done it both with & without -DNO_CLEAN have NOT removed /usr/obj yes, amd64 clean /usr/obj does NOT fix it. (In reply to Mariusz Zaborski from comment #1) r285138 builds cleanly on amd64 with custom kernel with options ZFS, without device nvme and device nvd, r285139 does not. (In reply to Trond.Endrestol from comment #4) Thank you for replay. I will look into it. Could you add please configuration which doesn't work? Created attachment 158415 [details]
config that breaks
(In reply to Mariusz Zaborski from comment #5) My custom kernel is this one: http://ximalas.info/~trond/create-zfs/canmount/VBOX-amd64-head Note that GENERIC was also affected, i.e. it compiled flawlessly on r285138, but not on r285139. Thank you for help. I confirm issue. I will work on it ASAP. Created attachment 158427 [details]
Patch
Could you pleas try this patch?
Please notice that the are renamed file in patch.
this patch DOES appear to fix it, albeit leaving some *.rej files around for the deletes. borg.lerctr.org /usr/src $ find . -name \*rej ./sys/contrib/libnv/nvlist.c.rej ./sys/contrib/libnv/dnvlist.c.rej ./sys/contrib/libnv/nvpair.c.rej borg.lerctr.org /usr/src $ borg.lerctr.org /usr/src $ (In reply to Mariusz Zaborski from comment #9) Patch works for me too. Can we get this committed???? Please don't rename it to prefix the filenames with "l", do it like we generally do elsewhere - use a recognizable prefix like libnv_. eg: the fdt files start with fdt_* and so on. (In reply to Larry Rosenman from comment #12) Yes, I was planing to upstream this today. (In reply to Peter Wemm from comment #14) No worries this was just test patch. A commit references this bug: Author: oshogbo Date: Thu Jul 9 21:53:42 UTC 2015 New revision: 285339 URL: https://svnweb.freebsd.org/changeset/base/285339 Log: Rename zfs nvpair files to not colidate with our nvlist. PR: 201356 Approved by: pjd (mentor) Changes: head/cddl/lib/libnvpair/Makefile head/sys/cddl/contrib/opensolaris/common/nvpair/fnvpair.c head/sys/cddl/contrib/opensolaris/common/nvpair/nvpair.c head/sys/cddl/contrib/opensolaris/common/nvpair/nvpair_alloc_fixed.c head/sys/cddl/contrib/opensolaris/common/nvpair/opensolaris_fnvpair.c head/sys/cddl/contrib/opensolaris/common/nvpair/opensolaris_nvpair.c head/sys/cddl/contrib/opensolaris/common/nvpair/opensolaris_nvpair_alloc_fixed.c head/sys/conf/files head/sys/modules/zfs/Makefile In r285339. A commit references this bug: Author: ngie Date: Wed Dec 23 04:36:16 UTC 2015 New revision: 292643 URL: https://svnweb.freebsd.org/changeset/base/292643 Log: MFC r282122,r285339,r288340: r282122 (by avg): nvpair_type_is_array: DATA_TYPE_INT8_ARRAY was not recognized To do: upstream (https://www.illumos.org/issues/5778) r285339 (by oshogbo): Rename zfs nvpair files to not colidate with our nvlist. PR: 201356 Approved by: pjd (mentor) r288340 (by avg): define aok in libnvpair which is linked to all zfs libraries that need aok This removes the circular dependency of libnvpair on libzfs / libzpool. PR: 199811 Obtained from: bapt Changes: _U user/ngie/stable-10-libnv/ user/ngie/stable-10-libnv/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c user/ngie/stable-10-libnv/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c user/ngie/stable-10-libnv/cddl/lib/libnvpair/Makefile user/ngie/stable-10-libnv/sys/cddl/contrib/opensolaris/common/nvpair/fnvpair.c user/ngie/stable-10-libnv/sys/cddl/contrib/opensolaris/common/nvpair/nvpair.c user/ngie/stable-10-libnv/sys/cddl/contrib/opensolaris/common/nvpair/nvpair_alloc_fixed.c user/ngie/stable-10-libnv/sys/cddl/contrib/opensolaris/common/nvpair/opensolaris_fnvpair.c user/ngie/stable-10-libnv/sys/cddl/contrib/opensolaris/common/nvpair/opensolaris_nvpair.c user/ngie/stable-10-libnv/sys/cddl/contrib/opensolaris/common/nvpair/opensolaris_nvpair_alloc_fixed.c user/ngie/stable-10-libnv/sys/conf/files user/ngie/stable-10-libnv/sys/modules/zfs/Makefile |