Summary: | [NEW PORT] sysutils/octopkg: Package manager for FreeBSD pkg packages | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jesse Smith <jsmith> | ||||||||||
Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | junovitch, kmoore, koobs, mikael, swills | ||||||||||
Priority: | --- | Keywords: | feature, needs-qa, patch | ||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
Description
Jesse Smith
2015-07-05 15:19:33 UTC
Created attachment 158381 [details]
Updated shell rchive of the octopkg port
This is an updated shar of the port with typos fixed and an improved COMMENT field.
Very cool. Can you add the QA output of 'poudriere testport ...' as well as 'portlint -AC' to go along with your submission? Created attachment 158405 [details]
slightly updated diff
Here's an updated version that passes portlint -ACNc and includes a .desktop entry and icon png so there's a nice icon. Look good to you?
(In reply to Steve Wills from comment #3) Why don't you use DESKTOP_ENTRIES in the port Makefile? DESKTOP_ENTRIES= "NAME" "COMMENT" "ICON" "COMMAND" "CATEGORY" StartupNotify DESKTOP_ENTRIES= "OctoPkg" "A powerful pkgng front-end" \ "${PREFIX}/share/pixmaps/octopi_green.png" \ "octopkg" "System;" false Thanks kmoore@! It looks like sysutils/octopkg was committed independently of this PR. Is there anything left for this PR to integrate or can this be called fixed? https://svnweb.freebsd.org/ports?view=revision&revision=391418 Oh, my bad I didn't realize there was another port of it in the works. If you have any changes / improvements you want to commit to the version I just added go for it! Created attachment 158447 [details]
Diff against existing port
Here's a diff against the existing port with all the changes that I think belong. Kris, this look OK to you?
That patch looks fine, go ahead and commit it when you are ready. A commit references this bug: Author: swills Date: Wed Jul 8 00:52:20 UTC 2015 New revision: 391540 URL: https://svnweb.freebsd.org/changeset/ports/391540 Log: ports-mgmt/octopkg: several improvements - Use DISTVERSIONPREFIX - Improve COMMENT - Improve deps by updating USE_QT5 - Allow build on 9.x by adding compiler:c++11-lib - Add desktop entry and icon PR: 201358 Approved by: kmoore (maintainer) Changes: head/ports-mgmt/octopkg/Makefile head/ports-mgmt/octopkg/distinfo head/ports-mgmt/octopkg/pkg-descr Committed, thanks to all. |