Bug 201486

Summary: [patch] games/minetest_game: add NO_ARCH, fix some libpng warnings
Product: Ports & Packages Reporter: Andriy Voskoboinyk <avos>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: patch
Priority: --- Flags: bugzilla: maintainer-feedback? (amdmi3)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile.diff
none
portlint.log
none
poudriere-9.3-i386.log
none
Makefile2.diff avos: maintainer-approval+

Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-11 23:34:31 UTC
Created attachment 158632 [details]
Makefile.diff

- Add NO_ARCH=yes.
- Use mogrify from graphics/ImageMagick for fixing "PNG warning: iCCP: RGB color space not permitted on grayscale PNG" and "PNG warning: iCCP: known incorrect sRGB profile" runtime warnings.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-11 23:35:39 UTC
Created attachment 158633 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-11 23:36:42 UTC
Created attachment 158634 [details]
poudriere-9.3-i386.log
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-07-13 17:36:15 UTC
I don't see a point of adding extra build dependency just to silence warnings, so you're better to address this issue upstream: https://github.com/minetest/minetest_game. NO_ARCH addition is good.
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-14 15:37:19 UTC
Created attachment 158754 [details]
Makefile2.diff
Comment 5 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-14 15:45:53 UTC
(In reply to Dmitry Marakasov from comment #3)
> I don't see a point of adding extra build dependency just to silence warnings,
> so you're better to address this issue upstream: https://github.com/minetest/minetest_game.

Ok (these warnings were already fixed in upstream).
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-07-14 15:59:38 UTC
A commit references this bug:

Author: amdmi3
Date: Tue Jul 14 15:58:53 UTC 2015
New revision: 392031
URL: https://svnweb.freebsd.org/changeset/ports/392031

Log:
  - Add NO_ARCH

  PR:		201486
  Submitted by:	s3erios@gmail.com

Changes:
  head/games/minetest_game/Makefile