Bug 201666
| Summary: | [patch] mail/postfixadmin - Missing dependencies for vacation script. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | ek | ||||||||
| Component: | Individual Port(s) | Assignee: | Carlo Strub <cs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Many People | CC: | cs, lukasz, ports.maintainer | ||||||||
| Priority: | --- | Keywords: | patch | ||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(ports.maintainer) |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 159059 [details]
Revised patch adding perl dependencies for vacation.pl
Thank you for catching this, and thank you for taking the time to hunt down the modules needed. The patch you provided was a good start--it only needed a few more bits to properly bring in the Ports System's methods for handling perl dependencies. Please try out attachment 159059 [details] and let me know if it works correctly.
Created attachment 159060 [details]
Second revision, get the dependencies right
Strike that that last, try attachment 159060 [details] instead. The odd way of making a port say "I need this package installed, don't go checking for a file, just install it if it isn't installed" always bites me.
Hi Mellisa, Thanks for looking into this and supplying the revised patch. It looks good and works just fine for me. Thank you for reviewing. Someone with a commit bit please commit attachment 159060 [details]. Thank you.
A commit references this bug: Author: cs Date: Fri Sep 11 23:18:00 UTC 2015 New revision: 396722 URL: https://svnweb.freebsd.org/changeset/ports/396722 Log: Add vacation script dependencies PR: 201666 Submitted by: ek@purplehat.org Approved by: Melissa Pilgrim (maintainer) Changes: head/mail/postfixadmin/Makefile Committed with slight rearrangements to please portlint. Thank you very much. |
Created attachment 158925 [details] Postfixadmin vacation script dependency patch. When running the vacation.pl script, the below Perl dependencies are missing: ${PORTSDIR}/mail/p5-MIME-EncWords ${PORTSDIR}/mail/p5-Email-Valid ${PORTSDIR}/mail/p5-Mail-Sender ${PORTSDIR}/devel/p5-Log-Log4perl ${PORTSDIR}/devel/p5-Log-Dispatch I've attached a Makefile patch but there may be a better way to handle it.