Bug 201680

Summary: [patch] astro/gpsbabel: add GUI option, clean up dependencies
Product: Ports & Packages Reporter: Andriy Voskoboinyk <avos>
Component: Individual Port(s)Assignee: Philip M. Gollucci <pgollucci>
Status: Closed FIXED    
Severity: Affects Only Me CC: dev2
Priority: --- Keywords: patch
Version: LatestFlags: dev2: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch.diff
none
portlint.log
none
poudriere-9.3-i386-no-gui.log
none
poudriere-9.3-i386-with-gui.log none

Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:09:27 UTC
Created attachment 158946 [details]
Patch.diff

- Add GUI option (requires qt4-gui,qt4-xml,qt4-network and qt4-webkit at runtime).
- Remove autoconf/pcre/glib20/gettext dependencies (unused).
- USE_QT4=linguist_build -> USE_QT4=linguisttools_build (GUI option only).
- Use system zlib.
- Regenerate patch.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:09:51 UTC
Created attachment 158947 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:10:09 UTC
Created attachment 158948 [details]
poudriere-9.3-i386-no-gui.log
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:11:25 UTC
Created attachment 158949 [details]
poudriere-9.3-i386-with-gui.log
Comment 4 Oliver Heesakkers 2015-08-02 11:41:51 UTC
I (maintainer) am OK with this.
Thanks for the patch!
Comment 5 Philip M. Gollucci freebsd_committer freebsd_triage 2015-08-12 01:51:22 UTC
Take.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-08-18 19:58:34 UTC
A commit references this bug:

Author: pgollucci
Date: Tue Aug 18 19:58:07 UTC 2015
New revision: 394642
URL: https://svnweb.freebsd.org/changeset/ports/394642

Log:
  astro/gpsbabel: add GUI option, clean up dependencies

  - Add GUI option (requires qt4-gui,qt4-xml,qt4-network and qt4-webkit at runtime).
  - Remove autoconf/pcre/glib20/gettext dependencies (unused).
  - USE_QT4=linguist_build -> USE_QT4=linguisttools_build (GUI option only).
  - Use system zlib.
  - Regenerate patch.

  PR:                  201680
  Submitted by:        s3erios@gmail.com
  Approved by:         dev2@heesakkers.info

Changes:
  head/astro/gpsbabel/Makefile
  head/astro/gpsbabel/files/patch-jeeps-gpslibusb.cc
  head/astro/gpsbabel/pkg-plist
Comment 7 Philip M. Gollucci freebsd_committer freebsd_triage 2015-08-18 20:07:21 UTC
Committed. Thanks!