Bug 201708
| Summary: | devel/m17n-lib: Update to 1.7.0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | amdmi3, nikola.lecic | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | amdmi3:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | 201707 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 159006 [details]
poudriere log
I do not approve this patch. Things that need to be resolved: 1) I don't see a reason to add USES=gettext; 2) This patch breaks textproc/scim-m17n (it probably needs a revision bump) and probably some other ports. Please give me 2-3 days to submit the updates. 1) Please observe executable /usr/local/bin/xgettext used in Makefile. Therefore it needs USES=gettext 2) I only use ibus and it works. Yes, maybe dependency versions need to be bumped. where does this one stand? (In reply to Nikola Lečić from comment #2) > 2) This patch breaks textproc/scim-m17n (it probably needs a revision bump) > and probably some other ports. Please give me 2-3 days to submit the updates. How exactly does it break it? Major library version has not been bumped, so ABI should be compatible. It also builds fine. (In reply to Nikola Lečić from comment #2) > I do not approve this patch. Things that need to be resolved: > > 1) I don't see a reason to add USES=gettext; It won't build without USES=gettext*: ===> Configuring for m17n-lib-1.7.0 Can't exec "autopoint": No such file or directory at /usr/local/share/autoconf-2.69/Autom4te/FileUtils.pm line 345. autoreconf-2.69: failed to run autopoint: No such file or directory autoreconf-2.69: autopoint is needed because this package uses Gettext Though it doesn't link with libintl, so it probably just needs USES=gettext-tools instead. Nikola, ping Dmitry, I see. In that case, I approve the patch. Sorry for the late reply, I completely lost this PR out of sight. Thanks! A commit references this bug: Author: amdmi3 Date: Fri May 13 18:05:21 UTC 2016 New revision: 415125 URL: https://svnweb.freebsd.org/changeset/ports/415125 Log: - Update to 1.7.0 PR: 201708 Submitted by: yuri@rawbw.com Approved by: nikola.lecic@anthesphoria.net (maintainer) Changes: head/devel/m17n-lib/Makefile head/devel/m17n-lib/distinfo head/devel/m17n-lib/files/patch-configure.ac head/devel/m17n-lib/pkg-plist |
Created attachment 159003 [details] patch