Bug 20173

Summary: send-pr(1) cannot override From: address [PATCH]
Product: Base System Reporter: Peter Pentchev <roam>
Component: gnuAssignee: Steve Price <steve>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Peter Pentchev 2000-07-25 13:50:00 UTC 
As can be seen from the above, I am using a local DNS domain oblivion.bg,
comprised of several virtual websites on the corporate LAN.  For various
reasons I prefer the primary hostname of my machine to be in that fake
domain.  Whenever I try to submit a PR, send-pr invokes sendmail as
root@ringwraith.oblivion.bg, and sometimes a picky SMTP relay along the
way rejects the mail.

Fix: Enclosed is a patch which checks if the environment variable FROM
is set, and if so, passes -f to sendmail.

I don't know if this is the best solution; it entails local changes,
yet the change is trivial.  I am also in doubt as to the name of the
environment variable which should hold the From: address of outgoing
mails; is there some convention as to that?

Anyway, here's a trivial patch.
How-To-Repeat: 
Invoke send-pr(1) from a machine with a primary hostname, unresolvable
by most of the world.
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-07-27 12:14:24 UTC 
Responsible Changed
From-To: freebsd-bugs->steve

Steve is probably the best person to make a call on this one.
Comment 2 Peter Pentchev 2000-08-17 17:25:21 UTC 
On Thu, Jul 27, 2000 at 04:14:51AM -0700, sheldonh@FreeBSD.org wrote:
> Synopsis: send-pr(1) cannot override From: address [PATCH]
> 
> Responsible-Changed-From-To: freebsd-bugs->steve
> Responsible-Changed-By: sheldonh
> Responsible-Changed-When: Thu Jul 27 04:14:24 PDT 2000
> Responsible-Changed-Why: 
> Steve is probably the best person to make a call on this one.
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=20173
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-bugs" in the body of the message
>

Actually, today's commit of jhb of send-pr.sh (MAIL_AGENT override)
pretty much covers this.  This PR may safely be closed :)

G'luck,
Peter

-- 
.sith ekil ti gnidaer eb d'uoy ,werbeH ni erew ecnetnes siht fI
Comment 3 Steve Price freebsd_committer freebsd_triage 2000-10-29 21:53:15 UTC 
State Changed
From-To: open->closed

As the originator pointed out this was fixed in revision 1.16 of 
send-pr.sh by nik@freebsd.org.