Bug 201741

Summary: mail/spamassassin: Fix DNS resolving incompatibility with Net::DNS 1.01
Product: Ports & Packages Reporter: Mark.Martinec
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Many People CC: Mark.Martinec, pi
Priority: --- Flags: bugzilla: maintainer-feedback? (perl)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
files/patch-DnsResolver.pm none

Description Mark.Martinec 2015-07-21 12:30:12 UTC
Created attachment 159045 [details]
files/patch-DnsResolver.pm

Now that a port dns/p5-Net-DNS has been upgraded to version 1.01,
this revealed an incompatibility with DNS resolving in SpamAssassin.

In short: Net::DNS::Packet->new no longer sets the RD (recursion
desired) bit in new packets, so essentially DNS queries no longer
work. Details at:
  https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7223

To bridge the time until SpamAssassin 3.4.2 gets released,
the attached patch is needed ( equivalent to
  https://svn.apache.org/viewvc?view=rev&rev=1691992 ).

For earlier version of dns/p5-Net-DNS this patch is redundant,
but does no harm.
Comment 1 Mark.Martinec 2015-07-21 12:31:30 UTC
Somehow I left out the affected port name, which is: mail/spamassassin
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2015-07-21 12:49:47 UTC
testing @work
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-07-21 12:57:27 UTC
A commit references this bug:

Author: pi
Date: Tue Jul 21 12:56:54 UTC 2015
New revision: 392630
URL: https://svnweb.freebsd.org/changeset/ports/392630

Log:
  mail/spamassassin, japanese/spamassassin: fix bug with dns/p5-Net-DNS change

  Now that a port dns/p5-Net-DNS has been upgraded to version 1.01,
  this revealed an incompatibility with DNS resolving in SpamAssassin.

  In short: Net::DNS::Packet->new no longer sets the RD (recursion
  desired) bit in new packets, so essentially DNS queries no longer
  work. Details at:
    https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7223

  To bridge the time until SpamAssassin 3.4.2 gets released,
  the attached patch is needed ( equivalent to
    https://svn.apache.org/viewvc?view=rev&rev=1691992 ).

  For earlier version of dns/p5-Net-DNS this patch is redundant,
  but does no harm.

  PR:		201741
  Submitted by:	Mark.Martinec@ijs.si

Changes:
  head/japanese/spamassassin/Makefile
  head/mail/spamassassin/Makefile
  head/mail/spamassassin/files/patch-DnsResolver.pm
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2015-07-21 13:01:39 UTC
Build worked on 10.1a, 9.3a, 10.1i.

japanese/spamassassin was already marked BROKEN. Volunteers ?