Bug 201886
| Summary: | [patch] lang/ghc: reorder some blocks, USES=metaport (bsd.cabal.mk) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andriy Voskoboinyk <avos> | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-haskell (Nobody) <haskell> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | pgj | ||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(haskell) |
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 159235 [details]
portlint.log
Created attachment 159236 [details]
hs-gtk2hs-9.3-i386-build.log
Created attachment 159237 [details]
hs-haskell-platform-9.3-i386-build.log
Hi Andriy, thanks for your work! I am fine with most of the proposed changes, although I do not see a reason for regenerating the patches. As far as I am aware, they do still apply, so they work as they should. I have been working on an update to 7.10.2, so they will probably be updated anyway. Anyhow, I have pushed the corresponding commit to our development staging repository [1], and I am planning to commit this to the ports tree soon. Please, raise your concerns if there are any. [1] https://github.com/freebsd-haskell/ports/commit/00cc8b123ac3024670916ae0093a87d5c76441bd (In reply to Gabor Pali from comment #4) > I am fine with most of the proposed changes, > although I do not see a reason for regenerating the patches. > As far as I am aware, they do still apply, so they work as they should. > I have been working on an update to 7.10.2, so they will probably be updated anyway. Yes, the patch regeneration is not necessary here (at least, bug 201647 states this). > Anyhow, I have pushed the corresponding commit to our development staging > repository [1], and I am planning to commit this to the ports tree soon. > Please, raise your concerns if there are any. Mostly OK (but you should insert PKGNAMESUFFIX between MASTER_SITES and DISTFILES - portlint(1) will complain about this). Thanks for pointing this out, though the PKGNAMESUFFIX appears only in the lang/ghc-devel port that is not present in the ports tree. Just in case, I have also fixed this in the development overlay. A commit references this bug: Author: pgj Date: Mon Aug 10 15:32:20 UTC 2015 New revision: 393873 URL: https://svnweb.freebsd.org/changeset/ports/393873 Log: - Implement a couple of portlint(1) warnings, such as moving the LICENSE block earlier, sort USES. This change also switches to USES=metaport for metaports, like haskell-platform or gtk2hs PR: 201886 Submitted by: Andriy Voskoboinyk <s3erios@gmail.com> Obtained from: FreeBSD Haskell Changes: head/lang/ghc/Makefile head/lang/ghc/bsd.cabal.mk The patch has been now committed. |
Created attachment 159234 [details] Patch.diff - Address some portlint warnings: -- Move LICENSE* block. -- Sort USES. -- Regenerate patches. - Replace some METAPORT-specific code with USES=metaport. As a result, devel/hs-haskell-platform and x11-toolkits/hs-gtk2hs now are marked as ARCH independent (NO_ARCH=yes).