Bug 202047

Summary:	www/apache22: r393440 breaks compile with LibreSSL
Product:	Ports & Packages	Reporter:	Adam McDougall <ebay>
Component:	Individual Port(s)	Assignee:	freebsd-apache (Nobody) <apache>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	ohauer, phil.stone
Priority:	---	Flags:	bugzilla: maintainer-feedback? (apache)
Version:	Latest
Hardware:	Any
OS:	Any

Description Adam McDougall 2015-08-02 23:48:55 UTC

r393440 may have reverted something that was improved in bug 196256 because apache 2.2.31 now gets a RAND_egd compile error again.  It had been fixed in the past: https://wiki.freebsd.org/LibreSSL#PC-BSD_10.1.2_ports_build

(00:01:14) /usr/local/share/apr/build-1/libtool --silent --mode=compile cc   -O2 -pipe -I/usr/local/include -fstack-protector -fno-strict-aliasing      -I. -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/os/unix -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/server/mpm/prefork -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/http -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/filters -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/proxy -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/include -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/generators -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/mappers -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/database -I/usr/local/include/apr-1 -I/usr/local/include -I/usr/local/include/db5 -I/usr/include -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/proxy/../generators -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/ssl -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/dav/main -prefer-pic -c ssl_engine_rand.c && touch ssl_engine_rand.slo
(00:01:14) ssl_engine_rand.c:92:26: warning: implicit declaration of function 'RAND_egd' is invalid in C99 [-Wimplicit-function-declaration]
(00:01:14)                 if ((n = RAND_egd(pRandSeed->cpPath)) == -1)
(00:01:14)                          ^
(00:01:14) 1 warning generated.
(00:01:15) /usr/local/share/apr/build-1/libtool --silent --mode=compile cc   -O2 -pipe -I/usr/local/include -fstack-protector -fno-strict-aliasing      -I. -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/os/unix -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/server/mpm/prefork -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/http -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/filters -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/proxy -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/include -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/generators -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/mappers -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/database -I/usr/local/include/apr-1 -I/usr/local/include -I/usr/local/include/db5 -I/usr/include -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/proxy/../generators -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/ssl -I/wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/dav/main -prefer-pic -c ssl_engine_vars.c && touch ssl_engine_vars.slo
(00:01:15) ssl_engine_vars.c:839:27: error: no member named 'compress_meth' in 'struct ssl_session_st'
(00:01:15)         switch (pSession->compress_meth) {
(00:01:15)                 ~~~~~~~~  ^
(00:01:15) 1 error generated.
(00:01:15) *** Error code 1
(00:01:15) 
(00:01:15) Stop.
(00:01:15) make[5]: stopped in /wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/ssl
(00:01:15) *** Error code 1
(00:01:15) 
(00:01:15) Stop.
(00:01:15) make[4]: stopped in /wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules/ssl
(00:01:15) *** Error code 1
(00:01:15) 
(00:01:15) Stop.
(00:01:15) make[3]: stopped in /wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31/modules
(00:01:15) *** Error code 1
(00:01:15) 
(00:01:15) Stop.
(00:01:15) make[2]: stopped in /wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31
(00:01:15) *** Error code 1
(00:01:15) 
(00:01:15) Stop.
(00:01:15) make[1]: stopped in /wrkdirs/usr/ports/www/apache22/work/httpd-2.2.31
(00:01:15) *** Error code 1
(00:01:15) 
(00:01:15) Stop.
(00:01:15) make: stopped in /usr/ports/www/apache22

Comment 1 phil.stone 2015-08-03 11:19:24 UTC

Same here.
Restoring the following files from 2.2.29 enables normal build:
/usr/ports/www/apache22/files/patch-modules__ssl__ssl_engine_rand.c
/usr/ports/www/apache22/files/patch-modules__ssl__ssl_engine_vars.c
/usr/ports/www/apache22/files/patch-modules__ssl__ssl_util_ssl.c
/usr/ports/www/apache22/files/patch-modules__ssl__ssl_util_ssl.h
Cheers,
Phil

Comment 2 Adam McDougall 2015-08-03 14:29:23 UTC

Thanks, I can confirm adding those 4 files back fixes the compile.

Comment 3 commit-hook freebsd_committer

2015-08-03 21:11:11 UTC

A commit references this bug:

Author: ohauer
Date: Mon Aug  3 21:10:31 UTC 2015
New revision: 393497
URL: https://svnweb.freebsd.org/changeset/ports/393497

Log:
  - re add libressl patches (lost by last cleanup commit)
  - no version bump, libressl is not the default ssl

  with hat: apache

  PR:			202047
  Submitted by:		mcdouga9 _at_ egr.msu.edu
  Patch Provided by:	phil.stone _at_ gmx.com

Changes:
  head/www/apache22/files/patch-modules__ssl__ssl_engine_rand.c
  head/www/apache22/files/patch-modules__ssl__ssl_engine_vars.c
  head/www/apache22/files/patch-modules__ssl__ssl_util_ssl.c
  head/www/apache22/files/patch-modules__ssl__ssl_util_ssl.h

Comment 4 Olli Hauer freebsd_committer

2015-08-03 21:13:01 UTC

Thanks for the report and sorry for the delay!

The 4 files are added again to the port, so libressl should be supported again