Bug 202090

Summary: [PATCH] multimedia/py-subliminal: update to 1.0.1, new dependency
Product: Ports & Packages Reporter: Andrej Ebert <andrej>
Component: Individual Port(s)Assignee: William Grzybowski <wg>
Status: Closed FIXED    
Severity: Affects Many People CC: jbeich
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (wg)
Hardware: Any   
OS: Any   
Bug Depends on: 202088    
Bug Blocks:    
Attachments:
Description Flags
svn diff
none
svn diff none

Description Andrej Ebert 2015-08-04 19:42:09 UTC
Created attachment 159551 [details]
svn diff

There's a new release, 1.0.1.(https://github.com/Diaoul/subliminal/releases/tag/1.0.1)

I have been able to build, install and run it successfully on my system, svn diff attached (i didn't change any comments, etc in the makefile, as i don't know what the proper format/etiquette is)

There are a few caveats:

The needed py-stevedore port is a bit old and won't play nice with the newer py-pbr, but there's a patch here: 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201639

It needs a newer guessit Version, see my patch for the port here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202088.

It has a new dependency, py-click>4.0, the port has 3.3.
I patched the py-click port also, see here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202084.
Comment 1 Andrej Ebert 2015-08-04 19:48:19 UTC
Comment on attachment 159551 [details]
svn diff

>Index: multimedia/py-subliminal/Makefile
>===================================================================
>--- multimedia/py-subliminal/Makefile	(revision 393546)
>+++ multimedia/py-subliminal/Makefile	(working copy)
>@@ -2,8 +2,7 @@
> # $FreeBSD$
> 
> PORTNAME=	subliminal
>-PORTVERSION=	0.7.5
>-PORTREVISION=	1
>+PORTVERSION=	1.0.1
> CATEGORIES=	multimedia python
> PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> 
>@@ -13,28 +12,22 @@
> LICENSE=	LGPL3
> 
> RUN_DEPENDS=	${PYTHON_SITELIBDIR}/bs4/__init__.py:${PORTSDIR}/www/py-beautifulsoup \
>-		${PYTHON_PKGNAMEPREFIX}enzyme>=0.4.0:${PORTSDIR}/multimedia/py-enzyme \
>-		${PYTHON_PKGNAMEPREFIX}guessit>=0.6.2:${PORTSDIR}/multimedia/py-guessit \
>-		${PYTHON_PKGNAMEPREFIX}requests>=2.0.1:${PORTSDIR}/www/py-requests \
>-		${PYTHON_PKGNAMEPREFIX}html5lib>=0.999:${PORTSDIR}/www/py-html5lib \
>-		${PYTHON_PKGNAMEPREFIX}chardet>0:${PORTSDIR}/textproc/py-chardet \
>+		${PYTHON_PKGNAMEPREFIX}enzyme>=0.4.1:${PORTSDIR}/multimedia/py-enzyme \
>+		${PYTHON_PKGNAMEPREFIX}guessit>=0.9.1:${PORTSDIR}/multimedia/py-guessit \
>+		${PYTHON_PKGNAMEPREFIX}requests>=2.0:${PORTSDIR}/www/py-requests \
>+		${PYTHON_PKGNAMEPREFIX}chardet>=2.3.0:${PORTSDIR}/textproc/py-chardet \
> 		${PYTHON_PKGNAMEPREFIX}pysrt>=1.0.1:${PORTSDIR}/textproc/py-pysrt \
>-		${PYTHON_PKGNAMEPREFIX}babelfish>=0.5:${PORTSDIR}/devel/py-babelfish \
>-		${PYTHON_PKGNAMEPREFIX}dogpile.cache>=0.5.2:${PORTSDIR}/devel/py-dogpile.cache \
>-		${PYTHON_PKGNAMEPREFIX}xdg>=0.25:${PORTSDIR}/devel/py-xdg \
>-		${PYTHON_PKGNAMEPREFIX}six>0:${PORTSDIR}/devel/py-six \
>-		${PYTHON_PKGNAMEPREFIX}argparse>0:${PORTSDIR}/devel/py-argparse
>+		${PYTHON_PKGNAMEPREFIX}babelfish>=0.5.2:${PORTSDIR}/devel/py-babelfish \
>+		${PYTHON_PKGNAMEPREFIX}dogpile.cache>=0.5.4:${PORTSDIR}/devel/py-dogpile.cache \
>+		${PYTHON_PKGNAMEPREFIX}six>=1.9.0:${PORTSDIR}/devel/py-six \
>+		${PYTHON_PKGNAMEPREFIX}argparse>0:${PORTSDIR}/devel/py-argparse \
>+		${PYTHON_PKGNAMEPREFIX}click>=4.0:${PORTSDIR}/devel/py-click 
> 
> USE_GITHUB=	yes
> GH_ACCOUNT=	Diaoul
>-GH_TAGNAME=	ea1fe66
>+GH_TAGNAME=	e0788be
> 
> USES=		python:2
> USE_PYTHON=	distutils autoplist
> 
>-post-patch:
>-	@${REINPLACE_CMD} -e 's;charade;chardet;g' \
>-                ${WRKSRC}/subliminal/providers/*.py \
>-		${WRKSRC}/requirements.txt
>-
> .include <bsd.port.mk>
>Index: multimedia/py-subliminal/distinfo
>===================================================================
>--- multimedia/py-subliminal/distinfo	(revision 393546)
>+++ multimedia/py-subliminal/distinfo	(working copy)
>@@ -1,2 +1,2 @@
>-SHA256 (Diaoul-subliminal-0.7.5-ea1fe66_GH0.tar.gz) = 51f0af733034443b8ef4f7f09fec595f9274aab92f283d14d15a09bfca2fe7bb
>-SIZE (Diaoul-subliminal-0.7.5-ea1fe66_GH0.tar.gz) = 35960
>+SHA256 (Diaoul-subliminal-1.0.1-e0788be_GH0.tar.gz) = 89342728b491fcc229913ccf492a705c7f45852dfaef98102e1bdd641b423452
>+SIZE (Diaoul-subliminal-1.0.1-e0788be_GH0.tar.gz) = 2493062
Comment 2 Andrej Ebert 2015-08-04 19:51:39 UTC
Created attachment 159553 [details]
svn diff

forgot to change the filename in distinfo
Comment 3 Andrej Ebert 2015-08-09 10:22:58 UTC
py-stevedore & py-click are up-to-date now.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-09-04 17:15:18 UTC
A commit references this bug:

Author: jbeich
Date: Fri Sep  4 17:14:27 UTC 2015
New revision: 396118
URL: https://svnweb.freebsd.org/changeset/ports/396118

Log:
  multimedia/py-subliminal: update to 1.0.1

  This fixes runtime since multimedia/py-guessit update in previous commit.

    $ subliminal
    Traceback (most recent call last):
      File "/usr/local/bin/subliminal", line 5, in <module>
        from pkg_resources import load_entry_point
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3074, in <module>
        @_call_aside
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3060, in _call_aside
        f(*args, **kwargs)
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3087, in _initialize_master_working_set
        working_set = WorkingSet._build_master()
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 647, in _build_master
        return cls._build_from_requirements(__requires__)
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 660, in _build_from_requirements
        dists = ws.resolve(reqs, Environment())
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 833, in resolve
        raise DistributionNotFound(req, requirers)
    pkg_resources.DistributionNotFound: The 'guessit<0.10,>=0.7' distribution was not found and is required by subliminal

  Changes:	https://github.com/Diaoul/subliminal/blob/master/HISTORY.rst#101
  PR:		202090 (based on)
  Approved by:	wg (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D3566

Changes:
  head/multimedia/py-subliminal/Makefile
  head/multimedia/py-subliminal/distinfo
Comment 5 Jan Beich freebsd_committer freebsd_triage 2015-09-04 17:20:24 UTC
Thanks. Committed.