Summary: | Missing support for fpsetround() | ||
---|---|---|---|
Product: | Base System | Reporter: | Sean Bruno <sbruno> |
Component: | arm | Assignee: | freebsd-arm (Nobody) <freebsd-arm> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | Andrew, emaste |
Priority: | --- | ||
Version: | CURRENT | ||
Hardware: | arm64 | ||
OS: | Any | ||
Bug Depends on: | |||
Bug Blocks: | 201763 |
Description
Sean Bruno
2015-08-07 18:25:37 UTC
I would like it if we don't need to implement these. I'm planning on a ports exp-run on amd64 to see what breaks when the fp* functions are removed. From tcl8.4.20/unix/tclUnixInit.c for reference:
> #if defined(__FreeBSD__) && defined(__GNUC__)
> /*
> * Adjust the rounding mode to be more conventional. Note that FreeBSD
> * only provides the __fpsetreg() used by the following two for the GNU
> * Compiler. When using, say, Intel's icc they break. (Partially based on
> * patch in BSD ports system from root@celsius.bychok.com)
> */
>
> fpsetround(FP_RN);
> fpsetmask(0L);
> #endif
Should we just add `&& !defined(__aarch64__)` to the conditional for now? lang/tcl86, failing due to lack of fpsetround, is responsible for 615 skipped ports in the arm64 quarterly ports build http://thunderx1.nyi.freebsd.org/build.html?mastername=110arm64-quarterly&build=421308 TCL has been fixed. Sean are you aware of any other ports affected by this? no, I think we're good here. I can't recall any others, but I'll keep my eye out. |