Summary: | print/gutenprint-base: unused module directory? | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||||||||
Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Some People | CC: | cmt | ||||||||||
Priority: | --- | Flags: | cmt:
maintainer-feedback+
|
||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 196321, 200017 | ||||||||||||
Attachments: |
|
Description
Dmitry Marakasov
2015-08-14 13:41:18 UTC
the modules directory is still referenced in the source code (being a little short on time, I did not check if that code is functional... but at least it isn't us who "invented" this directory). I can send a quick patch for this, around next weekend, I suppose. Ping? Created attachment 161014 [details]
fix and modernize gutenprint ports
patch relative to /usr/ports.
rollup of PRs 196321 200017 202324
Created attachment 161015 [details]
poudriere testport on gutenprint-base
Created attachment 161016 [details]
poudriere testport on gutenprint-cups
As there were patch conflicts, I rolled up the last gutenprint patches in this diff - perhaps they get committed now. The diff is broken. Your poudriere doesn't run stage-qa which should detect more errors. - You've removed @dir lib/gutenprint/5.2/modules, this is incorrect as it is still created - You've changed GUTENPRINTUI2_LIBS to pkgconfig --libs gutenprint, this breaks gimp-gutenprint - @dir lib/gutenprint/5.2/modules is still mentioned in some slave ports I've fixed these, attached is complete patch for all gutenprint ports, which build fine. If it's Ok with you, I can commit it right away. Created attachment 161074 [details]
Patch
Is the patch OK? looks good to me, and doesn't fall flat on it's face (cannot test more, for lack of hardware). Go ahead and commit :). Thanks. A commit references this bug: Author: amdmi3 Date: Tue Sep 22 23:59:07 UTC 2015 New revision: 397598 URL: https://svnweb.freebsd.org/changeset/ports/397598 Log: - Make GTK2 support optional - Fix module directory handling - Strip libraries - Minor fixes PR: 196321, 200017, 202324 Submitted by: mazhe@alkumuna.eu, yuri@rawbw.com, amdmi3@FreeBSD.org, cmt@burggraben.net (maintainer) Approved by: cmt@burggraben.net (maintainer) Changes: head/print/gimp-gutenprint/Makefile head/print/gutenprint-base/Makefile head/print/gutenprint-base/pkg-plist head/print/gutenprint-cups/pkg-plist |