Bug 202374

Summary: mail/opendmarc: Add dependencies for reporting tools
Product: Ports & Packages Reporter: Daniel Austin <freebsd-ports>
Component: Individual Port(s)Assignee: Matthew Seaman <matthew>
Status: Closed FIXED    
Severity: Affects Some People CC: douglas, matthew, pi
Priority: --- Keywords: easy, needs-qa, patch
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206413
Attachments:
Description Flags
add perl module dependancies
none
patch-v2 koobs: maintainer-approval+

Description Daniel Austin 2015-08-16 22:58:48 UTC 
Created attachment 159936 [details]
add perl module dependancies

Patch Makefile to pull in the necessary perl modules needed for the opendmarc reporting tools.

poudriere testport logs at:

https://poudriere2.dan.tm/poudriere/data/latest-per-pkg/opendmarc/1.3.1_1/
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-01-19 20:44:43 UTC 
Created attachment 165838 [details]
patch-v2
Comment 2 Daniel Austin 2016-01-19 21:05:52 UTC 
(In reply to Kurt Jaeger from comment #1)

Thanks for updating the patch Kurt, it looks fine to me - hopefully maintainer will be happy with it (although no reply from the August original submission!)

new poudriere testport logs at:

https://poudriere2.dan.tm/poudriere/data/latest-per-pkg/opendmarc/1.3.1_3/

10.2/amd64 are there now, others will follow shortly as they complete their runs.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-01-19 21:09:47 UTC 
(In reply to Daniel Austin from comment #2)
no reply from the August original submission ?

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206413, maybe maintainer never received the submission pointer ?
Comment 4 Daniel Austin 2016-01-19 21:11:26 UTC 
(In reply to Kurt Jaeger from comment #3)
Ah, that would be my fault due to the wrong summary - apologies!
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-20 04:27:20 UTC 
Comment on attachment 165838 [details]
patch-v2

MAINTAINER can't approve here if they can't be added to CC or Flag values. It doesnt appear current MAINTAINER matches any Bugzilla account emails.

Implicit approval (maintainer can't be notified)
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2016-01-20 05:23:58 UTC 
(In reply to Kubilay Kocak from comment #5)
The maintainer from the MAINTAINER field can be reached by sending him a mail outside of bugzilla (which I did). He'll check the PR.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-20 05:27:06 UTC 
(In reply to Kurt Jaeger from comment #6)

That's great! implicit approval stands :)
Comment 8 Matthew Seaman freebsd_committer freebsd_triage 2016-01-20 08:04:12 UTC 
I'll take this.  I've some other changes for this port as well.  Let's give the maintainer some time to respond.
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-02-06 23:13:20 UTC 
A commit references this bug:

Author: matthew
Date: Sat Feb  6 23:13:17 UTC 2016
New revision: 408319
URL: https://svnweb.freebsd.org/changeset/ports/408319

Log:
  (1) Add USES perl5 and add RUN_DEPENDS for perl modules needed by the
      various perl scripts installed by this port

  (2) Use ${PORTSDIR}/mail/sendmail/bsd.milter.mk to link against
      libmilter installed by the mail/sendmail port when
      WITH_SENDMAIL_PORT=yes is set in /etc/make.conf or the base
      libmilter if WITH_SENDMAIL_BASE=yes

  PR:		202374 (1)
  Submitted by:	freebsd-ports@dan.me.uk	(1) matthew (2)
  Reviewed by:	pi (1)
  Approved by:	maintainer timeout (>14days)

Changes:
  head/mail/opendmarc/Makefile
Comment 10 Matthew Seaman freebsd_committer freebsd_triage 2016-02-06 23:15:10 UTC 
Committed, thanks!
Comment 11 Douglas Thrift 2016-02-07 04:30:55 UTC 
*** Bug 204887 has been marked as a duplicate of this bug. ***