Bug 202574

Summary: [patch] fix editors/emacs* build with FORTIFY_SOURCE - fix a misused umask parameter
Product: Ports & Packages Reporter: Oliver Pinter <op>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Some People CC: ashish, pfg, xmj
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: ashish: maintainer-feedback+
ashish: merge-quarterly-
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202311
Attachments:
Description Flags
editors-emacs.diff none

Description Oliver Pinter freebsd_committer 2015-08-22 16:34:40 UTC
Created attachment 160215 [details]
editors-emacs.diff
Comment 1 Johannes Jost Meixner freebsd_committer 2015-08-22 17:11:54 UTC
Assign to ashish@ (maintainer)
Comment 2 Ashish SHUKLA freebsd_committer 2015-08-22 19:48:03 UTC
Hi,

Could you please report these upstream, if you've not already done so ?

I'll test/build with these diffs, and get back to you, if any issues.

Thanks!
Comment 3 Oliver Pinter freebsd_committer 2015-08-22 19:50:58 UTC
already done: http://lists.gnu.org/archive/html/bug-gnu-emacs/2015-08/msg00445.html
Comment 4 commit-hook freebsd_committer 2015-08-23 21:19:34 UTC
A commit references this bug:

Author: ashish
Date: Sun Aug 23 21:19:18 UTC 2015
New revision: 395132
URL: https://svnweb.freebsd.org/changeset/ports/395132

Log:
  - Add patches to fix misused umask parameter, caught with FORTIFY_SOURCE

  PR:		202574
  Submitted by:	op

Changes:
  head/editors/emacs/Makefile
  head/editors/emacs/files/patch-src_unexaix.c
  head/editors/emacs/files/patch-src_unexcoff.c
  head/editors/emacs/files/patch-src_unexelf.c
Comment 5 Ashish SHUKLA freebsd_committer 2015-08-24 08:21:54 UTC
Thanks, the changes are committed.

I'm merging to quarterly branch, as this does not seem like a security issue, and nor intrusive to experience, IMHO.