Bug 202605

Summary: audio/audacity: convert SSE to option helpers and PORTMIXER to target helpers
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: xxjack12xx
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (xxjack12xx)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v0
none
QA: poudriere testport -j 93i386
none
QA: poudriere testport -j 93amd64 none

Description Jan Beich freebsd_committer freebsd_triage 2015-08-24 00:44:29 UTC
Created attachment 160275 [details]
v0

MACHINE_CPU check can be optimized away via OPTIONS_DEFAULT and powerpc conditional that required .include <bsd.port.pre.mk> is gone. The patch makes it possible to force-enable or force-disable SSE support regardless of CPUTYPE. By default i386 package remains without SSE, while amd64 with it. This also fixes a case when MACHINE_CPU is not defined e.g., for new architectures not in bsd.cpu.mk.

And take advantage of /usr/ports/CHANGES from 20150701.

Both make it possible to eliminate duplicate inclusion of bsd.port.mk.
Comment 1 Jack 2015-08-24 01:32:12 UTC
Looks ok.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2015-08-24 02:27:41 UTC
Created attachment 160279 [details]
QA: poudriere testport -j 93i386
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-08-24 02:27:44 UTC
Created attachment 160280 [details]
QA: poudriere testport -j 93amd64
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-08-24 08:30:38 UTC
A commit references this bug:

Author: jbeich
Date: Mon Aug 24 08:30:18 UTC 2015
New revision: 395161
URL: https://svnweb.freebsd.org/changeset/ports/395161

Log:
  audio/audacity: convert to more option helpers

  - Restore SSE option removed in r331611
  - Keep SSE default only to amd64 or i386 + custom CPUTYPE
  - Convert PORTMIXER to target option helper

  PR:		202605
  Approved by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile