Summary: | audio/soundtouch: enable INTEGER_SAMPLES on armv6 by default | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||||||||
Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||||||||
Status: | Closed Overcome By Events | ||||||||||||
Severity: | Affects Only Me | CC: | freebsd-arm, imp, w.schwarzenfeld | ||||||||||
Priority: | --- | Keywords: | feature, patch | ||||||||||
Version: | Latest | ||||||||||||
Hardware: | arm | ||||||||||||
OS: | Any | ||||||||||||
See Also: |
https://bugzilla.mozilla.org/show_bug.cgi?id=1047791 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203179 |
||||||||||||
Attachments: |
|
Description
Jan Beich
2015-08-25 06:00:52 UTC
Created attachment 160335 [details]
QA: poudriere testport -j armv6
Created attachment 160363 [details] v1 Adjusted against base 287137 to include arm/arm (v7 little endian) and arm/armeb (v7 big endian). Created attachment 160364 [details]
v2
Simplified.
I've removed the softfp for armv6 because it turns out that it's too ambiguous for the arm developer community to sign off on. I was premature, it seems, in pushing it upstream. It's defined for arm and armeb, but I doubt anybody will be running sounttouch / mozilla there. Sorry for any hassles this causes. armv6 is softfp ABI. However, it has full floating point support, so it should likely use it on armv6 unless measurements prove it too slow. ports r395349 unbroke configure www/firefox on armv6 while breaking on arm and armeb. armv6 build still fails due to clang crash, though. http://beefy8.nyi.freebsd.org/data/head-armv6-default/p395445_s287222/logs/firefox-40.0_6,1.log Since MACHINE_CPU still exposes softfp on some architectures I plan to land the patch here after approval or maintainer timeout. If softfp in MACHINE_CPU is renamed to something less ambiguous in future it shouldn't be hard to find all makefiles that check softfp and update them. A commit references this bug: Author: jbeich Date: Thu Sep 17 18:53:19 UTC 2015 New revision: 397202 URL: https://svnweb.freebsd.org/changeset/ports/397202 Log: audio/soundtouch: adjust options - Make INTEGER_SAMPLES default on platforms with emulated floating point to be in sync with r395349 [1] - Fix SSE detection on 9.x by requesting a modern compiler with cpuid.h [2] PR: 202642 [1], 202646 [2] Approved by: maintainer timeout (3 weeks) Changes: head/audio/soundtouch/Makefile Thanks. Committed. Cannot close because our bugzilla is too pedantic: Bug 202642 has 1 unresolved dependency. They must either be resolved or removed from the "Depends on" field before you can resolve this bug as FIXED. Is this still relevant? |