Bug 202699

Summary: [patch] Fix PDF Problem in Korean Documentation
Product: Documentation Reporter: Hoyoung Kim <trig4800>
Component: Books & ArticlesAssignee: Warren Block <wblock>
Status: Closed FIXED    
Severity: Affects Some People CC: doceng, wblock
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Archived ko_KR.UTF-8 directory.
none
diff file
none
Affected files none

Description Hoyoung Kim 2015-08-27 21:19:25 UTC 
Created attachment 160424 [details]
Archived ko_KR.UTF-8 directory.

In this revision, the problem related to Korean character(a lot of
###s instead of proper Korean characters in PDF, PS and RTF outputs)
was fixed.

korean/nanumfonts-ttf (popular open source Korean font) is required to
build Korean documentation.  Please consider adding this in CJK
support option of textproc/docproj and server-side build of
documentation.  Current PDF, PS and RTF files on FreeBSD FTP are not
appropriate:

ftp://ftp.freebsd.org/pub/FreeBSD/doc/ko_KR.UTF-8/
Comment 1 Warren Block freebsd_committer freebsd_triage 2015-08-27 22:44:24 UTC 
It is not clear whether the attachment is the existing version or a patched version.  If it is the patched version, it is difficult to see what has been changed.  Can you supply a diff (svn diff) against the existing Korean docs tree?
Comment 2 Hoyoung Kim 2015-08-28 00:10:20 UTC 
Created attachment 160425 [details]
diff file
Comment 3 Hoyoung Kim 2015-08-28 00:10:53 UTC 
Created attachment 160426 [details]
Affected files
Comment 4 Hoyoung Kim 2015-08-28 00:12:03 UTC 
(In reply to Warren Block from comment #1)

I generated diff file but it seems not showing the changes correctly(I attached it anyway).
I also attached only affected files in seperate archive(korean-share-xml-changes.tar.gz).
Please check those two files.

All changes are described below:

- ko_KR.UTF-8/share/xml/freebsd-dblatex.xsl was added.
- ko_KR.UTF-8/share/xml/freebsd-fo.xsl was added.
- ko_KR.UTF-8/share/xml/freebsd-xhtml.xsl was added.
- ko_KR.UTF-8/share/xml/catalog.xml was modified.
- ko_KR.UTF-8/share/xml/l10n.ent was slightly modified(doc.langcode.en -> doc.langcode.ko in line 17-18).

Changes were based on The FreeBSD Japanese Documentation Project.
Comment 5 Warren Block freebsd_committer freebsd_triage 2015-08-28 16:00:35 UTC 
Modification to textproc/docproj: https://reviews.freebsd.org/D3509
Comment 6 Warren Block freebsd_committer freebsd_triage 2015-08-28 16:20:40 UTC 
Modification to the doc build system: https://reviews.freebsd.org/D3520
Comment 7 Hoyoung Kim 2015-08-29 18:36:08 UTC 
(In reply to Warren Block from comment #5)

In the line 58 of textproc/docproj/Makefile, is 'NanumBarunGothic.ttf' intended instead of 'NanumGothic.ttf'?  (In fact, those two fonts are almost same.)

I think everything else is fine.  Thanks.
Comment 8 Warren Block freebsd_committer freebsd_triage 2015-08-30 13:50:12 UTC 
That is just the first file in the list of files installed by the korean/nanumfonts-ttf port.  It is only used to detect whether that port is installed.
Comment 9 Hoyoung Kim 2015-08-30 18:06:56 UTC 
(In reply to Warren Block from comment #8)

Okay, I got it.
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-09-01 13:42:00 UTC 
A commit references this bug:

Author: wblock
Date: Tue Sep  1 13:41:40 UTC 2015
New revision: 395751
URL: https://svnweb.freebsd.org/changeset/ports/395751

Log:
  Add Korean font support to the CJK option.

  PR:		202699
  Submitted by:	Hoyoung Kim <trig4800@gmail.com>
  Approved by:	hrs, mat
  Differential Revision:	https://reviews.freebsd.org/D3509

Changes:
  head/textproc/docproj/Makefile
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-09-01 13:50:02 UTC 
A commit references this bug:

Author: wblock
Date: Tue Sep  1 13:49:42 UTC 2015
New revision: 47333
URL: https://svnweb.freebsd.org/changeset/doc/47333

Log:
  Add Korean language support to the doc build system.  Modified version
  of that supplied in the PR.

  PR:		202699
  Submitted by:	Hoyoung Kim <trig4800@gmail.com>
  Approved by:	doceng (implicit)
  Differential Revision:	https://reviews.freebsd.org/D3520

Changes:
  head/ko_KR.UTF-8/share/xml/catalog.xml
  head/ko_KR.UTF-8/share/xml/freebsd-dblatex.xsl
  head/ko_KR.UTF-8/share/xml/freebsd-fo.xsl
  head/ko_KR.UTF-8/share/xml/freebsd-xhtml.xsl
  head/ko_KR.UTF-8/share/xml/l10n.ent
Comment 12 Warren Block freebsd_committer freebsd_triage 2015-09-01 13:51:41 UTC 
Changes committed in r47332 and r47333.  Thanks!