Bug 20296

Summary: matcd driver is a) not in GENERIC and b) broken
Product: Base System Reporter: george.russell <george.russell>
Component: kernAssignee: Sheldon Hearn <sheldonh>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   

Description george.russell 2000-07-30 03:20:01 UTC
The matcd driver for Matsushita CR 562/3 CD roms drives is claimed as 
supported. Two things - you can't install from it - GENERIC does not
support it. The driver is also broken. A fix is available here as a 
gzipped c code file, not a patch. Its from 4.0 Stable, so use patch 
against that. I don't have the unmodified version anymore, so I  
cannot make a patch from it.

Fix: 

http://www.george.russell.clara.net/matcd.c.gz is a fixed version of the driver.
Tested on one machine, and works again for audio and data.
How-To-Repeat: I note the 4.1 release notes still claims support - I have recieved no update on my
previous pr about the driver.
Comment 1 billf 2000-07-30 07:07:28 UTC
On Sat, Jul 29, 2000 at 07:18:14PM -0700, george.russell@clara.net wrote:
> 
> >Number:         20296
> >Category:       kern
> >Synopsis:       matcd driver is a) not in GENERIC and b) broken

The reason it's not in GENERIC is _because_ it is broken.

-- 
Bill Fumerola - Network Architect, BOFH / Chimes, Inc.
                billf@chimesnet.com / billf@FreeBSD.org
Comment 2 george.russell 2000-07-30 14:32:00 UTC
Bill Fumerola wrote:
> 
> On Sat, Jul 29, 2000 at 07:18:14PM -0700, george.russell@clara.net wrote:
> >
> > >Number:         20296
> > >Category:       kern
> > >Synopsis:       matcd driver is a) not in GENERIC and b) broken
> 
> The reason it's not in GENERIC is _because_ it is broken.

Great. I thought it was removed for space reasons.

Download a fixed version for 4.0 stable from
http://www.george.russell.clara.net/matcd.c.gz

George Russell
(does this mean it'll go back into stable, and say in 4.2 I could
actually install without copying XXXMb of files to a disk partition?
Good)
Comment 3 Sheldon Hearn freebsd_committer freebsd_triage 2000-07-31 13:45:34 UTC
State Changed
From-To: open->feedback

Before anyone looks at your alternative matcd.c, could you 
let us know whether the patch in PR kern/17605 works for you? 
See http://www.ferebsd.org/cgi/query-pr.cgi?17605 .
Comment 4 Sheldon Hearn 2000-08-14 13:51:39 UTC
On Thu, 10 Aug 2000 21:53:57 +0100, GeorgE Russell wrote:

> Not for me it doesn't work, unfortunately.
> Sorry for taking so long to reply.

No problem.  I'm looking at your patch, and it appears to be against an
older revision of matcd.c.  Could you produce a patch against rev 1.54
instead?

Ciao,
Sheldon.
Comment 5 Sheldon Hearn 2000-08-16 15:45:45 UTC
On Mon, 14 Aug 2000 18:27:02 +0100, GeorgE Russell wrote:

> OTOH, if you could describe the steps needed to get that revision from
> web cvs and update / patch my version, then I can do that, if you think
> that revision will work with 4.0

By the way, what does your version actually do, other than replace
matcdc with matcd?  I tried diffing what you've got with what's in
CURRENT and that's all I could see, in amongst the noise of the
COMPAT_ISA shim stuff and the buf -> bio changes.

Ciao,
Sheldon.
Comment 6 pscott 2000-08-23 06:49:57 UTC
I tried to install the 4.1 release off CDROM and the fix was still not
applied. But after installing from the 'Net (thank the deity I have a FAST
DSL line), I applied the patch, recompiled, and all's right with the world.

The patch from <a
href="http://www.freebsd.org/cgi/query-pr.cgi?pr=17605">kern/17605</a> also
works on FreeBSD 4.1 without modification. It's an obvious typo, both in the
code and the author's comment <20>.

Will someone please put this fix into the 4.x branch? There are still some
of us who use that antiquated device!

Paul A. Scott
mailto:pscott@the-frontier.org
http://www.the-frontier.org/pscott/
Comment 7 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-23 10:16:31 UTC
State Changed
From-To: feedback->open

Feedback acquired. 


Comment 8 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-23 10:16:31 UTC
Responsible Changed
From-To: freebsd-bugs->sheldonh

I'll take this one.
Comment 9 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-23 10:43:42 UTC
State Changed
From-To: open->feedback

Committed to HEAD and merged onto RELENG_4 as rev 1.49.2.1 
of matcd.c. 

Please confirm that this works again. :-)
Comment 10 kristian.hansen 2000-09-22 13:37:26 UTC
Hi,

I'm using this very old cd drive, and can happily report that I've compiled a 4.0 kernel (from the March 2000 CD set) and a 4.1-release kernel with the modified matcd.c source and it works for data.

There may to be some issues regarding audio cd, but I haven't been able to test that properly yet.

There are some issues regarding the use of the debug options in the code (from options.h) where the compilation will report some warnings.

Also the autohunt code seems not to be working, so it is not possible to specify 
device matcd0 port ? irq?
in the kernel configuration file.

Regards

Kristian Hansen,
Bæktoften 86
DK-2680 Solrød Strand
Tlf: +45 5614 9764
E-Mail: kristian.hansen@post.tele.dk
Comment 11 Sheldon Hearn freebsd_committer freebsd_triage 2001-05-28 22:19:44 UTC
State Changed
From-To: feedback->closed

Resolved ages ago.