Bug 202974

Summary:	games/ioquake3-devel: plist broken
Product:	Ports & Packages	Reporter:	Dmitry Marakasov <amdmi3>
Component:	Individual Port(s)	Assignee:	Dmitry Marakasov <amdmi3>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	kamikaze
Priority:	---	Flags:	bugzilla: maintainer-feedback? (kamikaze)
Version:	Latest
Hardware:	Any
OS:	Any

Description Dmitry Marakasov freebsd_committer

2015-09-08 16:59:43 UTC

http://poudriere.amdmi3.ru/data/10-amd64-default/all_2015_08_11/logs/errors/ioquake3-devel-g2390_2.log

---
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DOCSDIR%%/opengl2-readme.txt
===> Error: Plist issues found.
...
pkg-static: duplicate file listing: /usr/local/share/doc/ioquake3-devel/opengl2-readme.txt, fatal (developer mode)
---

This seemingly happens because Q3DOCS contains opengl2-readme.txt for ioquake3-devel, and it's added again from this part of ioquake3 Makefile:

---
.if ${PORT_OPTIONS:MDLRENDERER}
MAKE_ARGS+=     USE_RENDERER_DLOPEN=1
. if ${IOQ3:MOPENGL2}
Q3DOCS+=        opengl2-readme.txt
. endif
.else
MAKE_ARGS+=     USE_RENDERER_DLOPEN=0
.endif
---

Actually, I would suggest reworking these ports as they seem to be too complicated. I'd make ioquake3-devel standalone port (not a slave of ioquake3), convert to option helpers, use explicit install commands (e.g. do-install-OPTION-on: targets instead of incomprehensible IOQ3_INST logic), PORTDOCS=*, simplify IOQ3 logic (it seems to be only used for server slave port). You also don't need to ${CAT} ${PKGMESSAGE} from ports' Makefile.

Comment 1 commit-hook freebsd_committer

2015-10-09 18:21:37 UTC

A commit references this bug:

Author: amdmi3
Date: Fri Oct  9 18:20:44 UTC 2015
New revision: 398930
URL: https://svnweb.freebsd.org/changeset/ports/398930

Log:
  - Fix duplicate plist entry in ioquake3-devel
  - Don't cat pkg-message from Makefile

  PR:		202974
  Submitted by:	amdmi3
  Approved by:	maintainer timeout (kamikaze@bsdforen.de, 1 month)

Changes:
  head/games/ioquake3/Makefile