Bug 203103
| Summary: | [patch] archivers/xarchiver: convert some GNU tar options, add few optional compression formats | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andriy Voskoboinyk <avos> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Danilo Egea Gondolfo <danilo> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | CC: | avos | ||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(danilo) |
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 197296 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 161042 [details]
portlint.log
Created attachment 161043 [details]
poudriere-9.3-i386.log
Created attachment 161044 [details]
poudriere-10.2-amd64.log
Thanks for your work. Just one question (for now): is the change in src/window.c necessary? The magic number of lzma files is \x5d\x00\x00\x80. (In reply to Danilo Egea Gondolfo from comment #4) I think that yes, because first four bytes of curl distfile (curl-7.44.0.tar.lzma) are 5d 00 00 00, not 5d 00 00 80 - and it is correctly identified by file(1) and still extractable by tar(1). Actually the 4th byte depends on the compression level. Try this: $ lzma -z -9 a $ lzma -z -0 b $ dd if=a.lzma bs=1 count=10 | hd ... 00000000 5d 00 00 00 04 ff ff ff ff ff |].........| $ dd if=b.lzma bs=1 count=10 | hd ... 00000000 5d 00 00 04 00 ff ff ff ff ff |].........| Your patch seems to be right. A commit references this bug: Author: danilo Date: Thu Sep 17 00:12:21 UTC 2015 New revision: 397093 URL: https://svnweb.freebsd.org/changeset/ports/397093 Log: - Replace '--touch' option with '-m' - Fix '--use-compress-program' usage with bsdtar where needed - Improve LZMA detection - Add missing dependency to zipinfo (required to view contents of ZIP archives) - Add ARJ and LZO options - Sort USES while here - Add RAR option PR: 203103 Submitted by: Andriy Voskoboinyk <s3erios@gmail.com> MFH: 2015Q3 Changes: head/archivers/xarchiver/Makefile head/archivers/xarchiver/files/ head/archivers/xarchiver/files/patch-src_bzip2.c head/archivers/xarchiver/files/patch-src_tar.c head/archivers/xarchiver/files/patch-src_window.c A commit references this bug: Author: danilo Date: Thu Sep 17 13:55:49 UTC 2015 New revision: 397113 URL: https://svnweb.freebsd.org/changeset/ports/397113 Log: MFH: r397093 - Replace '--touch' option with '-m' - Fix '--use-compress-program' usage with bsdtar where needed - Improve LZMA detection - Add missing dependency to zipinfo (required to view contents of ZIP archives) - Add ARJ and LZO options - Sort USES while here - Add RAR option PR: 203103 Submitted by: Andriy Voskoboinyk <s3erios@gmail.com> Approved by: ports-secteam (feld) Changes: _U branches/2015Q3/ branches/2015Q3/archivers/xarchiver/Makefile branches/2015Q3/archivers/xarchiver/files/ Committed. Thanks! |
Created attachment 161041 [details] Patch.diff - Replace '--touch' option with '-m'. - Fix '--use-compress-program' usage with bsdtar where needed. - Improve LZMA detection. - Add missing dependency to zipinfo (required to view contents of ZIP archives). - Add ARJ and LZO options. - Sort USES. - Bump PORTREVISION.