Bug 20311

Summary:	src/release/Makefile: broken CHECKSUM.MD5
Product:	Base System	Reporter:	Makoto Matsushita <matusita>
Component:	bin	Assignee:	Mark Murray <markm>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	5.0-CURRENT
Hardware:	Any
OS:	Any

Description Makoto Matsushita 2000-07-31 12:20:00 UTC

	target 'release.7' of src/release/Makefile does make a source
	distributions such as src/sbase.* etc.

	This target does
		- Create tarball for earch src/* directory
		- Do additional tarball listed in EXTRA_SRC
		- Move crypto-related source to ../crypto

	... but all MD5 signature of src/scrypto.* (and crypto-related
	source file chunks) are still in src/CHECKSUM.MD5.

	Moreover, crypto/CHECKSUM.MD5 have only *krb5* checksums.

Fix: 

CHECKSUM.MD5 should be created *after* all distributions are
	placed as it is.

	An example to fix:
		- stop creating CHECKSUM.MD5 in 'doTARBALL' target
		- creating CHECKSUM.MD5 in the end of 'release.7'
How-To-Repeat: 
	Do 'make buildworld' and see the results.

Comment 1 Sheldon Hearn freebsd_committer

2000-07-31 13:31:16 UTC

Responsible Changed
From-To: freebsd-bugs->markm

Mark, this is the problem that DES complained about recently.

Comment 2 Makoto Matsushita 2000-09-27 05:30:44 UTC

Here is a status of this PR.

* Assigned to a person. No respondings yet.

* CHECKSUM.MD5 is still broken. It also affected to 4.1.1-RELEASE
  (if you doubt, check 4.1.1-RELEASE/crypto/CHECKSUM.MD5).

-- -
Makoto `MAR' MATSUSHITA

Comment 3 Makoto Matsushita 2000-12-05 05:58:07 UTC

(forward to stable/current also, to open this problem widely)

matusita> * CHECKSUM.MD5 is still broken. It also affected to 4.1.1-RELEASE

I cannot believe that this problem is still there, and CHECKSUM.MD5s
of 4.2-RELEASE/{src,crypto} are also broken.

However, it's easy to fix just like this (CAUTION: I don't test with this):

Index: Makefile
===================================================================
RCS file: /lab/FreeBSD/FreeBSD.cvs/src/release/Makefile,v
retrieving revision 1.586
diff -c -r1.586 Makefile
*** Makefile	2000/11/21 04:37:30	1.586
--- Makefile	2000/12/05 05:43:41
***************
*** 503,509 ****
  		if [ -f ssecure.aa ] ; then mv ssecure.* ../crypto ; fi && \
  		if [ -f scrypto.aa ] ; then mv scrypto.* ../crypto ; fi && \
  		if [ -f skrb4.aa ] ; then mv skrb4.* ../crypto ; fi && \
! 		if [ -f skrb5.aa ] ; then mv skrb5.* ../crypto ; fi ; ) ; fi
  	@echo "src distribution is finished."
  .endif
  	touch release.7
--- 503,512 ----
  		if [ -f ssecure.aa ] ; then mv ssecure.* ../crypto ; fi && \
  		if [ -f scrypto.aa ] ; then mv scrypto.* ../crypto ; fi && \
  		if [ -f skrb4.aa ] ; then mv skrb4.* ../crypto ; fi && \
! 		if [ -f skrb5.aa ] ; then mv skrb5.* ../crypto ; fi ; \
! 		cd ${RD}/dists/crypto; rm -f CHECKSUM.MD5; \
! 		md5 * > CHECKSUM.MD5 ) ; fi
! 	(cd ${RD}/dists/src; rm -f CHECKSUM.MD5; md5 * > CHECKSUM.MD5)
  	@echo "src distribution is finished."
  .endif
  	touch release.7

But if creating CHECKSUM.MD5 files are already totally broken feature,
we can simply remove all CHECKSUM.MD5 files.

-- -
Makoto `MAR' MATSUSHITA

Comment 4 Mark Murray freebsd_committer

2002-01-30 15:22:49 UTC

State Changed
From-To: open->closed

Originator says problem is fixed satisfactorily.