Bug 203121

Summary: devel/libinotify - [PATCH] update to latest available version
Product: Ports & Packages Reporter: Matthew Seaman <matthew>
Component: Individual Port(s)Assignee: Xin LI <delphij>
Status: Closed FIXED    
Severity: Affects Some People Keywords: patch
Priority: --- Flags: bugzilla: maintainer-feedback? (delphij)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update to devel/libinotify port
none
poudriere testport output
none
Results of running the testsuite none

Description Matthew Seaman freebsd_committer freebsd_triage 2015-09-15 12:12:26 UTC
Created attachment 161051 [details]
Update to devel/libinotify port

Update to commit b2873cf8a94b0574819075a003e33c0405f1b690

   - Now uses autotools to configure

One consequence of switching to autotools is that it is now simple to run the test suite.  FreeBSD has some missing kqueue(2) functionality which means that there will be test failures around:

  - detecting a file being moved into or out of a directory within the
    same filesystem
  - certain modifications to a symbolic link (rather than the
    file it points to.)

The upstream author has some kernel patches to address these:

   https://github.com/dmatveev/libinotify-kqueue/tree/master/patches

These are in addition to the already known and documented limitations on detecting file open and close events.
Comment 1 Matthew Seaman freebsd_committer freebsd_triage 2015-09-15 12:13:09 UTC
Created attachment 161053 [details]
poudriere testport output
Comment 2 Matthew Seaman freebsd_committer freebsd_triage 2015-09-15 12:17:43 UTC
Created attachment 161055 [details]
Results of running the testsuite

Note: running the test suite as root will result in an additional test failure

In test "Failures":
    failed: watch id is -1, errno set to EACCES when starting watching a file without read access

Upstream believe this to be a testsuite bug.
Comment 3 Xin LI freebsd_committer freebsd_triage 2015-09-16 00:58:26 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-09-16 00:58:39 UTC
A commit references this bug:

Author: delphij
Date: Wed Sep 16 00:58:14 UTC 2015
New revision: 397035
URL: https://svnweb.freebsd.org/changeset/ports/397035

Log:
  Update to latest (20150910) git version.

  PR:		203121
  Submitted by:	matthew

Changes:
  head/devel/libinotify/Makefile
  head/devel/libinotify/distinfo
  head/devel/libinotify/files/
  head/devel/libinotify/pkg-message
  head/devel/libinotify/pkg-plist