Bug 203131

Summary:

sysutils/rsyslog8 [PATCH] update to 8.12.0, etc.

Product:

Ports & Packages

Reporter:

Matthew Seaman <matthew>

Component:

Individual Port(s)

Assignee:

Brad Davis <brd>

Status:

Closed Overcome By Events

Severity:

Affects Some People

Keywords:

patch

Priority:

---

Flags:

bugzilla: maintainer-feedback? (brd)

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
update to sysutils/rsyslog8 port	none
poudriere testport output	none
Update sysutils/rsyslog8 to 8.13.0	matthew: maintainer-approval?
poudriere testport output for rsyslog-8.13.0	none

Description Matthew Seaman freebsd_committer

2015-09-15 16:19:15 UTC

Created attachment 161071 [details]
update to sysutils/rsyslog8 port

Update to 8.12.0

  - Remove most of the required patches as the code has been incorporated
    upstream
  - Set MAKE_JOBS_UNSAFE as there's a race condition that breaks compilation
    otherwise
  - Patch configure.ac so it can detect pthread_setschedparam(3) correctly --
    function needs -lpthread on FreeBSD.
  - Add a new INOTIFY option, but mark it BROKEN for now.

The new (optional) support for 'notify' mode in the imfile module provided by linking against devel/libinotify will compile perfectly and the resulting binary runs happily.  Unfortunately the 'notify' mode does not notice any changes to the monitored file, *unless* rsyslogd is started with the '-n' (no auto-background) flag.  Which makes it pretty useless, especially since it is so frustratingly close to working correctly.

The INOTIFY option works because rsyslog8's configure mechanism is broken with respect to testing for inotify_init() functionality where that function is not in libc. (Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202862) Enabling the option adds a fix to configure.ac so it can properly detect inotify_init() in libinotify.so, but this would compile in inotify support unconditionally if that library happens to be present on the system.

This update should also fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202932 -- that patch has apparently been included upstream.

Comment 1 Matthew Seaman freebsd_committer

2015-09-15 16:19:54 UTC

Created attachment 161072 [details]
poudriere testport output

Comment 2 Matthew Seaman freebsd_committer

2015-10-08 15:25:07 UTC

Created attachment 161830 [details]
Update sysutils/rsyslog8 to 8.13.0


Beyond what was changed in the previous update:

Upstream has fixed multi-threaded compilation

Drop all attempts at enabling inotify support (via libinotify) as it is never going to work due to a fundamental difference between Linux inotify and the kqueue based replacement provided by libinotify -- the former will continue to work in a forked child, whereas the latter will not.  

configure no longer provides a --enable-cached-man-pages option

Comment 3 Matthew Seaman freebsd_committer

2015-10-08 15:25:57 UTC

Created attachment 161831 [details]
poudriere testport output for rsyslog-8.13.0