Bug 203154

Summary: Fix databases/rocksdb build with clang 3.7.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (sunpoet)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 201377    
Attachments:
Description Flags
Fix rocksdb warnings with clang 3.7.0 none

Description Dimitry Andric freebsd_committer freebsd_triage 2015-09-16 12:48:04 UTC 
Created attachment 161118 [details]
Fix rocksdb warnings with clang 3.7.0

During the exp-run in bug 201377, it was found that databases/rocksdb gives errors with clang 3.7.0:

http://package18.nyi.freebsd.org/data/headamd64PR201377-default/2015-09-16_07h08m17s/logs/errors/rocksdb-3.13.1.log

This is because of several new warnings produced by the code, and the rocksdb Makefiles defaulting to -Werror.  Specifically:
- Pessimizing std::move() invocations in a number of places.
- A few printf() format mismatches.
- One constant integer overflow.

I have fixed all the warnings in the attached patch.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-09-28 14:25:02 UTC 
A commit references this bug:

Author: sunpoet
Date: Mon Sep 28 14:24:10 UTC 2015
New revision: 398116
URL: https://svnweb.freebsd.org/changeset/ports/398116

Log:
  - Fix warning generated by recent snapshot of Clang 3.7.0, including:
    - Pessimizing std::move() invocations in a number of places.

  PR:		203154
  Submitted by:	dim

Changes:
  head/databases/rocksdb/files/patch-db-db_bench.cc
  head/databases/rocksdb/files/patch-db-wal_manager.cc
  head/databases/rocksdb/files/patch-utilities-backupable-backupable_db.cc
  head/databases/rocksdb/files/patch-utilities-document-json_document.cc
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-09-28 14:27:26 UTC 
Committed. Thanks!