Bug 203167

Summary: deskutils/owncloudclient - Upgrade to v2 to fix "Choose What to Sync" sorting error
Product: Ports & Packages Reporter: Yonas Yanfa <yonas>
Component: Individual Port(s)Assignee: Jason Unovitch <junovitch>
Status: Closed FIXED    
Severity: Affects Only Me CC: junovitch
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/owncloud/client/issues/3854
Attachments:
Description Flags
deskutils/owncloudclient: update 1.84 -> 2.0.1
none
Output of `truss owncloud`
none
GDB backtrace on core dump
none
Output of ldd /usr/local/bin/owncloud none

Description Yonas Yanfa 2015-09-17 02:12:39 UTC
Hi,

When reporting this bug upstream, they said v1.8.x is old, and we should use v2.0.1.

Cheers,
Yonas
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-09-20 02:31:37 UTC
Created attachment 161208 [details]
deskutils/owncloudclient: update 1.84 -> 2.0.1

Can you try this at let me know if everything works at runtime?
Comment 2 Yonas Yanfa 2015-09-20 03:29:35 UTC
Created attachment 161210 [details]
Output of `truss owncloud`
Comment 3 Yonas Yanfa 2015-09-20 03:34:52 UTC
Created attachment 161211 [details]
GDB backtrace on core dump
Comment 4 Yonas Yanfa 2015-09-20 03:35:44 UTC
(In reply to Jason Unovitch from comment #1)

Hi Jason, running /usr/local/bin/owncloud crashed. I've attached some debugging info.
Comment 5 Yonas Yanfa 2015-09-20 14:06:34 UTC
I compiled owncloudclient in a fresh virtual machine and everything seems to work fine.

The crash is probably because of some incompatibility between packages and compiled ports.
Comment 6 Jason Unovitch freebsd_committer freebsd_triage 2015-09-20 14:33:08 UTC
(In reply to Yonas Yanfa from comment #5)
I was just about to post myself.

(In reply to Yonas Yanfa from comment #4)
What does `ldd /usr/local/bin/owncloud` return?

There appears to be a mix and match of the system OpenSSL and the ports OpenSSL.  I don't use this application myself but if we can get to the bottom of that we can see if this is ready to commit.

#0  0x00000008062e67d3 in ssl_create_cipher_list () from /usr/local/lib/libssl.so.8
#1  0x000000081aa3009b in SSL_CTX_new () from /usr/lib/libssl.so.7
Comment 7 Jason Unovitch freebsd_committer freebsd_triage 2015-09-20 14:37:28 UTC
If run time looks good in that VM then we'll chalk the earlier issue up to that machine's configuration.  I just need to validate builds on all releases then and this is commit ready.

Do you use this port regularly?  This doesn't have a maintainer and having someone to submit the occasional maintainer update would help immensely in the future.
Comment 8 Yonas Yanfa 2015-09-20 15:01:55 UTC
Created attachment 161213 [details]
Output of ldd /usr/local/bin/owncloud

Here's the output of ldd.
Comment 9 Jason Unovitch freebsd_committer freebsd_triage 2015-09-20 15:04:39 UTC
(In reply to Yonas Yanfa from comment #8)
The ldd shows it is linking to the base OpenSSL. A dependency must have WITH_OPENSSL_PORT set.
Comment 10 Yonas Yanfa 2015-09-20 15:08:08 UTC
(In reply to Jason Unovitch from comment #7)

Yes, I use owncloud a fair bit. I'd be happy to help maintain this port, although I may need help with writing the FreeBSD compatibility patches if required by newer versions.
Comment 11 Jason Unovitch freebsd_committer freebsd_triage 2015-09-20 15:12:38 UTC
(In reply to Yonas Yanfa from comment #10)
Ok.  Good to hear.  Having someone who uses is a big help keeping quality up.  If you need help, there's always a shout to ports@FreeBSD.org or on IRC to see if you can find someone more familiar with things.

Do you want to look further into things with the mix and match on your first test machine or does everything look good so far in the clean VM?
Comment 12 Yonas Yanfa 2015-09-20 15:15:22 UTC
(In reply to Jason Unovitch from comment #9)

I think that's right. `which openssl` on my desktop (where it crashed) shows /usr/local/bin/openssl, but on the virtual machine, it shows /usr/bin/openssl.

I'm curious, how did you tell that it was linking against the openssl port? ldd shows 'libssl.so.7 => /usr/lib/libssl.so.7' on both desktop and virtual machine.
Comment 13 Yonas Yanfa 2015-09-20 15:18:57 UTC
(In reply to Jason Unovitch from comment #11)

I'm thinking the easiest thing to do is build a package for v2.0.1. I didn't have any issues when installing v1.8.0 via a package, so hopefully it'll "just work" again :P
Comment 14 Jason Unovitch freebsd_committer freebsd_triage 2015-09-20 15:19:28 UTC
(In reply to Yonas Yanfa from comment #12)
See the first two lines of the backtrace in comment 6. It shows both the base and ports libssl.so.# library.
Comment 15 Jason Unovitch freebsd_committer freebsd_triage 2015-09-20 15:23:13 UTC
(In reply to Yonas Yanfa from comment #13)
OK, then we'll commit the patch plus setting you as maintainer. Then the official package will be built in the clean environment outside whatever went wrong on your local machine.
Comment 16 Yonas Yanfa 2015-09-20 15:25:22 UTC
(In reply to Jason Unovitch from comment #15)

Sounds good. Feel free to close this when you're ready.
Comment 17 commit-hook freebsd_committer freebsd_triage 2015-09-21 12:29:48 UTC
A commit references this bug:

Author: junovitch
Date: Mon Sep 21 12:29:38 UTC 2015
New revision: 397491
URL: https://svnweb.freebsd.org/changeset/ports/397491

Log:
  deskutils/owncloudclient: update 1.8.4 -> 2.0.1

  - Pass maintainer from ports@ to PR submitter
  - Regenerate a patch for 2.0.1

  PR:		203167
  Submitted by:	Yonas Yanfa <yonas@fizk.net>

Changes:
  head/deskutils/owncloudclient/Makefile
  head/deskutils/owncloudclient/distinfo
  head/deskutils/owncloudclient/files/patch-src_gui_generalsettings.cpp
Comment 18 Jason Unovitch freebsd_committer freebsd_triage 2015-09-21 12:34:26 UTC
This took quite a while for Poudriere runs.  Builds were tested on:
9.3-RELEASE-p25  amd64
9.3-RELEASE-p25  i386
10.1-RELEASE-p19 amd64
10.1-RELEASE-p19 i386
10.2-RELEASE-p2  amd64
10.2-RELEASE-p2  i386
11.0-CURRENT r287698 amd64
11.0-CURRENT r287698 i386

Portlint was good.
% portlint -ac
looks fine.

Closing PR. Thanks for the report and testing.