Bug 203226

Summary:

Improve plaintext email template not to include invalid "(Bug ID)" text

Product:

Services

Reporter:

linpct

Component:

Bug Tracker

Assignee:

Oleksandr Tymoshenko <gonzo>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

bugmeister, gonzo, mmokhi

Priority:

Normal

Keywords:

easy, needs-patch, needs-qa

Version:

unspecified

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
mail screenshot	none

Description linpct 2015-09-21 03:06:30 UTC

Created attachment 161219 [details]
mail screenshot

Each time when I send-pr, I'd received a bugzilla mail said that
"To view an individual PR, use:
  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id)."

But, the "?id=(Bug Id)" should be "?id=<real bug id, a number>", jusk like "https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203203."

Thanks.

Comment 1 Kubilay Kocak freebsd_committer

2015-11-02 05:41:25 UTC

I believe the messaging you refer to is only in plain text emails, and is intended only to be a hint/indication to the recipient that they should append the Issue ID's (further in the body of the email) to the end of the URL stated.

Given that email can contain multiple issue ID's, the link at the top of the email is not supposed to be clickable.

Any user can get proper individually clickable links by switching your email preferences from plain text to HTML.

This unfortunately, coupled with the fact that some MUA's (Gmail in this case) conveniently can render links in plaintext emails, means that in this case the URL appears actionable, but in fact is not intended to be so.

I think we should re-evaluate the contents of these plain text email templates to insure that they don't convey any conflicting/ambiguous information.

Comment 2 linpct 2015-11-03 04:41:41 UTC

Thanks for your reply, I have no problem on it now.

Comment 3 Kubilay Kocak freebsd_committer

2015-11-03 05:39:18 UTC

(In reply to linpct from comment #2)

Thanks for the reply. Do you mean no problem after switching to HTML from Plain Text, or no problem its not reproducible anymore?

Comment 4 linpct 2015-11-04 11:19:47 UTC

I mean I got it, it's a table with multiple PRs, I think it's not an important issue and could been improved at further days.

So we could let this issue been closed if currently we have no improvement ideas.

Thanks.

Comment 5 Oleksandr Tymoshenko freebsd_committer

2018-02-24 06:38:17 UTC

https://github.com/gonzoua/bugzilla/commit/46463cc0629d399c2ca36147f955b826538e97ee

weeklyreminder.pl now sends multipart/altenative email with two versions: plain text and HTML. They're more or less the same except bug IDs and summaries are links to bugs.freebsd.org. 

(Also script has been broken since August 2017, it's fixed now)