Bug 20326

Summary: [PATCH] installkernel fails if DESTDIR is empty
Product: Base System Reporter: k <k>
Component: miscAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.1-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description k 2000-07-31 21:30:01 UTC 
	When building/installing world and a kernel by:

	# make buildworld
	# make buildkernel
	# make DESTDIR=foo installkernel
	# make DESTDIR=foo installworld
	
	the installkernel will fail if DESTDIR is an empty directory.

	Since this is the recomended way by src/UPDATING one would 
	expect this to work.

How-To-Repeat: 
	# make buildworld
	# make buildkernel
	# make DESTDIR=path_to_empty_dir installkernel
Comment 1 Marcel Moolenaar freebsd_committer freebsd_triage 2000-07-31 22:03:06 UTC 
Responsible Changed
From-To: freebsd-bugs->marcel
Comment 2 k 2000-10-13 20:19:55 UTC 
In current this will not fail any more due to changes in the 
src/sys/module/*/Makefile, where David changes the install
target to only install programs if the destdir exists.
(eg. src/sys/modules/svr4/Makefile rev 1.19)

However I belive this only hides the problem since some 
programs will be missing if one only do:
# make buildworld
# make buildkernel
# make DESTDIR=foo installkernel
# make DESTDIR=foo installworld


One still has to run the installkernel again after the installworld
to get all the programs.

In 4-Stable it will still fail.

/Johan K
Comment 3 Marcel Moolenaar freebsd_committer freebsd_triage 2004-02-14 08:16:01 UTC 
Responsible Changed
From-To: marcel->ru

After mentioning this PR to Ruslan, he replied that he has been using 
a similar patch for a while. Re-assign to Ruslan at his invitation.
Comment 4 ru freebsd_committer freebsd_triage 2004-03-14 14:59:10 UTC 
State Changed
From-To: open->patched

Fixed in 5.2-CURRENT, in src/Makefile.inc1,v 1.416.
Comment 5 ru freebsd_committer freebsd_triage 2004-03-16 08:35:28 UTC 
State Changed
From-To: patched->closed

Fixed in 4.9-STABLE, in src/Makefile.inc1,v 1.141.2.66.
Comment 6 ru freebsd_committer freebsd_triage 2004-03-16 08:35:28 UTC 
Responsible Changed
From-To: ru->freebsd-bugs