Bug 203307

Summary: www/node: fails to build on FreeBSD 9.3-RELEASE because of dependency to gcc48 not enforced in Makefile
Product: Ports & Packages Reporter: François Charlier <fcharlier>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Many People CC: linpct, lukasz, milios, pi
Priority: --- Flags: bugzilla: maintainer-feedback? (linpct)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile patch none

Description François Charlier 2015-09-24 11:47:45 UTC
Created attachment 161334 [details]
Makefile patch

www/node fails to build on FreeBSD 9.3-RELEASE because of dependency to gcc48 not enforced in Makefile.

The attached patch allows the port to build.
Comment 1 Chad Jacob Milios 2015-09-25 04:56:18 UTC
+1
worked great for me, built and running my [albeit simple] app on node-4.1.1 on FreeBSD 9.3-RELEASE-p26/amd64
Comment 2 linpct 2015-10-01 16:53:28 UTC
Maintainer approved.

Since we have clang at FreeBSD 10+, I think we could apply the patch.

Thanks.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-01 17:41:35 UTC
testing@work.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-01 17:42:03 UTC
*** Bug 203370 has been marked as a duplicate of this bug. ***
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-01 17:46:45 UTC
A commit references this bug:

Author: pi
Date: Thu Oct  1 17:46:25 UTC 2015
New revision: 398375
URL: https://svnweb.freebsd.org/changeset/ports/398375

Log:
  www/node: fix build on 9.3

  - enforce dependency on gcc48 on 9.3

  PR:		203307
  Submitted by:	fcharlier@ploup.net
  Approved by:	linpct@gmail.com (maintainer)

Changes:
  head/www/node/Makefile
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-01 17:47:00 UTC
Committed, thanks!
Comment 7 linpct 2015-10-01 17:48:04 UTC
Thanks for helping.