Bug 203353
| Summary: | devel/nspr: Needs arm64 support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ed Maste <emaste> | ||||
| Component: | Individual Port(s) | Assignee: | Andrew Turner <Andrew> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | Andrew, gecko | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||
| Hardware: | arm64 | ||||||
| OS: | Any | ||||||
| See Also: | https://bugzilla.mozilla.org/show_bug.cgi?id=1228299 | ||||||
| Attachments: |
|
||||||
|
Description
Ed Maste
2015-09-25 20:14:04 UTC
Created attachment 162769 [details] Patch to build on arm64 The attached patch, based on https://bugzilla.mozilla.org/show_bug.cgi?id=827271. lets me build nspr. Are there any issues with this patch? I'd like to commit it to allow us to build more ports on arm64. Comment on attachment 162769 [details] Patch to build on arm64 Looks good as long as you avoid touching a patch submitted upstream. |make makepatch| even with ports r401709 currently cannot handle ../ in paths, so use a plain editor (see diffutils unified format). (In reply to Jan Beich from comment #3) I don't understand this comment. Comment on attachment 162769 [details] Patch to build on arm64 >Index: devel/nspr/files/patch-bug782109 >=================================================================== >--- devel/nspr/files/patch-bug782109 (revision 400734) >+++ devel/nspr/files/patch-bug782109 (working copy) >@@ -1,20 +1,3 @@ >---- ../pr/include/md/_freebsd.h~ >-+++ ../pr/include/md/_freebsd.h >-@@ -47,6 +47,14 @@ >- #define _PR_HAVE_LARGE_OFF_T >- >- #if defined(_PR_PTHREADS) >-+#if __FreeBSD_version >= 602000 >-+#define _PR_HAVE_GETPROTO_R >-+#define _PR_HAVE_5_ARG_GETPROTO_R >-+#endif >-+#if __FreeBSD_version >= 700016 >-+#define _PR_HAVE_GETHOST_R >-+#define _PR_HAVE_GETHOST_R_INT >-+#endif >- #if __FreeBSD_version >= 400008 >- /* >- * libc_r before this version of FreeBSD doesn't have poll(). This change is unrelated to aarch64. Remove. >Index: devel/nspr/files/patch-pr-include-md-freebsd.h >=================================================================== >--- devel/nspr/files/patch-pr-include-md-freebsd.h (nonexistent) >+++ devel/nspr/files/patch-pr-include-md-freebsd.h (working copy) >@@ -0,0 +1,26 @@ >+--- ../pr/include/md/_freebsd.h.orig 2015-08-19 15:32:22.000000000 +0000 >++++ ../pr/include/md/_freebsd.h 2015-11-04 11:38:01.257876000 +0000 [...] >+@@ -57,6 +59,14 @@ >+ #define _PR_HAVE_LARGE_OFF_T >+ >+ #if defined(_PR_PTHREADS) >++#if __FreeBSD_version >= 602000 >++#define _PR_HAVE_GETPROTO_R >++#define _PR_HAVE_5_ARG_GETPROTO_R >++#endif >++#if __FreeBSD_version >= 700016 >++#define _PR_HAVE_GETHOST_R >++#define _PR_HAVE_GETHOST_R_INT >++#endif >+ #if __FreeBSD_version >= 400008 >+ /* >+ * libc_r before this version of FreeBSD doesn't have poll(). This change is unrelated to aarch64. Remove. A commit references this bug: Author: andrew Date: Sun Nov 22 10:26:23 UTC 2015 New revision: 402224 URL: https://svnweb.freebsd.org/changeset/ports/402224 Log: devel/nspr: Add support for arm64. PR: 203353 Approved by: jbeich Changes: head/devel/nspr/files/patch-pr-include-md-freebsd.cfg head/devel/nspr/files/patch-pr-include-md-freebsd.h Is anything further required by this PR? In discussion with andrew@ from our (arm64) perspective there's no need for this bug to remain open. The maintainer may want to merge to the quarterly branch (if it helps future merges, for example). (In reply to Ed Maste from comment #7) Closing bugs is usually done by whoever lands or the reporter. (In reply to Ed Maste from comment #8) > may want to merge to the quarterly branch pkg-fallout@ only builds -quaterly packages for Tier1 platforms. Assign to Committer that resolved Was supposed to keep maintainer (gecko) cc'd, not gnome@ |