Bug 203371
| Summary: | [patch] libc.so patch for worlds built WITHOUT_SSP - should not add libssp_nonshared.a | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Kenneth Salerno <kennethsalerno> | ||||||
| Component: | bin | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||||
| Status: | Closed Overcome By Events | ||||||||
| Severity: | Affects Only Me | CC: | jlh, pfg | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | 11.0-RELEASE | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 176591 [details]
fix for WITHOUT_SSP
It looks reasonable to me (except for the $FreeBSD$ string) but I'll leave it for jlh@ since he knows this better. Sorry for the long delay... It seems it was fixed in r307146: https://svnweb.freebsd.org/base/head/lib/libc/Makefile?revision=307146&view=markup (In reply to Jeremie Le Hen from comment #3) I find it very interesting how Ruslan Bukin came up with a patch in Oct 2016 identical to my patch from Sep 2015. The only difference is he used _nossp in his ldscript name while I used -nossp. |
Created attachment 161421 [details] patch to check for WITHOUT_SSP Should check first if WITHOUT_SSP was chosen before including /usr/lib/libssp_nonshared.a in libc.so which will not exist on those systems, breaking cc.