Bug 20341

Summary: Support for PCI multiport cards for sio driver
Product: Base System Reporter: vak <vak>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
file.diff none

Description vak 2000-08-01 13:40:01 UTC 
	To handle non-intelligent multiport async adapters,
	the sio driver lacks the PCI detection and attachment routines.
	Some rearrangment of the sio.c is also required.

	The patch consists of four parts:
	1) sys/isa/siovar.h (new file)
	2) sys/isa/sio.c (patch)
	3) sys/pci/sio_pci.c (new file)
	4) sys/conf/files.i386 (patch)

Fix: 1) Move the struct com_s definition to separate file siovar.h.
2) Split the sioattach() routine. Leave the isa-dependent
   part in sioattach(), and build the (public) bus-independent 
   attachment function sio_attach_unit().
3) Make siointr1 public.
Comment 1 Poul-Henning Kamp 2000-08-09 20:11:42 UTC 
Hi Sergey,

this looks like fundamentally good stuff, but the patch blows up on FreeBSD
current.  Is there any chance you could submit a patch for -current ?

--
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD coreteam member | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.
Comment 2 vak 2000-08-10 08:46:01 UTC 
Hi Poul,

> this looks like fundamentally good stuff, but the patch blows up on
FreeBSD
> current.  Is there any chance you could submit a patch for -current ?

OK, I will try to make the patch set for -current.
It will take some time, though...
___
Serge Vakulenko
Comment 3 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-10 10:34:56 UTC 
State Changed
From-To: open->feedback

phk reckons that this is good stuff and is waiting for a patch 
against a recent -current.
Comment 4 vak 2000-08-10 16:20:13 UTC 
I sent a new patch for -current:

http://www.freebsd.org/cgi/query-pr.cgi?pr=20523

__
Serge Vakulenko
Comment 5 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-11 09:51:38 UTC 
State Changed
From-To: feedback->closed

Superseded by kern/20523.