Summary: | [MAINTAINER] www/geneweb: Update to 6.08, Mark Un'BROKEN | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | alex |
Component: | Individual Port(s) | Assignee: | Pawel Pekala <pawel> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | koobs, pawel, portmgr, ports-secteam |
Priority: | --- | Keywords: | easy, needs-patch, needs-qa, patch, regression |
Version: | Latest | Flags: | koobs:
merge-quarterly?
|
Hardware: | Any | ||
OS: | Any |
Description
alex
2015-10-03 05:43:58 UTC
Thanks Alex! Could you split these two changes (version update, mark unbroken fix) up into individual diffs please. This will enable one to be committed to the 2015Q4 quarterly branch (where it is still broken). Please also include them as attachments here, rather than links hosted offsite. On the other hand, Pawel, can you handle these two changes separately? koobs: I don't see any reason why this cannot be merged to stable branch as a whole maintainer: GTK2 option seems to be bogus, while it uses plist substitution, there are none substitutions in plist file, can you check this issue? @Pawel I don't mind, might be worth checking with portmgr|ports-secteam as I know version updates (all else being equal) are undesirable @Pawel: GTK2 option was added in commit 312150 to support an experimental GTK2 UI in GeneWeb v6.06. It looks like its references in plist got removed in commit 354265, when I updated to GeneWeb v6.07 and added staging. As near as I can remember, I think it didn't look like the experimental GTK2 UI was included in the distribution anymore (hence its removal from the plist), however I left the option in place in case it would resurface in a later revision. I am OK with the removal of the GTK2 option. @Kubilay: I uploaded the attachments externally because I was used to the old PR system not being able to handle large diffs. I'll try to remember to upload directly into Bugzilla. Regarding splitting this diff, I can do it, but if it's really not necessary, then I'd be happier to avoid the extra work. I'll wait to hear back on this. A commit references this bug: Author: pawel Date: Thu Nov 5 17:02:41 UTC 2015 New revision: 400857 URL: https://svnweb.freebsd.org/changeset/ports/400857 Log: - Update to version 6.08, remove BROKEN, now hosted on GitHub [1] - Unmute install commands [1] - Remove GTK2 option, it's not working couple versions back PR: 203522 [1] Submitted by: Alex Strangl (maintainer) [1] MFH: 2015Q4 Changes: head/www/geneweb/Makefile head/www/geneweb/distinfo head/www/geneweb/files/patch-Makefile head/www/geneweb/files/patch-dag2html__Makefile head/www/geneweb/files/patch-ged2gwb__utf8.ml head/www/geneweb/files/patch-src__Makefile head/www/geneweb/files/patch-tools__Makefile.inc.unix head/www/geneweb/pkg-plist A commit references this bug: Author: pawel Date: Thu Nov 5 18:53:59 UTC 2015 New revision: 400861 URL: https://svnweb.freebsd.org/changeset/ports/400861 Log: MFH: r400857 - Update to version 6.08, remove BROKEN, now hosted on GitHub [1] - Unmute install commands [1] - Remove GTK2 option, it's not working couple versions back PR: 203522 [1] Submitted by: Alex Strangl (maintainer) [1] Approved by: ports-secteam (feld) Changes: _U branches/2015Q4/ branches/2015Q4/www/geneweb/Makefile branches/2015Q4/www/geneweb/distinfo branches/2015Q4/www/geneweb/files/patch-Makefile branches/2015Q4/www/geneweb/files/patch-dag2html__Makefile branches/2015Q4/www/geneweb/files/patch-ged2gwb__utf8.ml branches/2015Q4/www/geneweb/files/patch-src__Makefile branches/2015Q4/www/geneweb/files/patch-tools__Makefile.inc.unix branches/2015Q4/www/geneweb/pkg-plist |