Bug 203747

Summary: java/openjdk8: Respect CC
Product: Ports & Packages Reporter: Sean Bruno <sbruno>
Component: Individual Port(s)Assignee: freebsd-java (Nobody) <java>
Status: Closed FIXED    
Severity: Affects Some People CC: frebsd-java, freebsd-arm, glewis, java, jkim
Priority: --- Keywords: needs-patch, needs-qa, patch
Version: LatestFlags: koobs: maintainer-feedback? (java)
Hardware: arm   
OS: Any   
Attachments:
Description Flags
patch toolchain.m4 with support for non-default CC
none
patch toolchain.m4 with support for non-default CC
none
An alternate patch to Makefile none

Description Sean Bruno freebsd_committer freebsd_triage 2015-10-13 18:09:28 UTC
Created attachment 161992 [details]
patch toolchain.m4 with support for non-default CC

Patch to add non-default CC locations to java build.  Helps me build openjdk8 via poudriere + qemu due to use of non-default CC toolchains.  Submitted by Steve Kiernan from Juniper.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-10-13 23:09:03 UTC
To what file should this patch be applied?
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2015-10-14 15:16:43 UTC
(In reply to Mark Linimon from comment #1)
Its a patch file for java/openjdk8/files/ ... not a patch to be applied to java/openjdk8
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-19 09:33:15 UTC
@Sean, Can you provide the patch against the port please (you can use `make makepatch` for simplicity and correctness if you'd like)

Also, has this passed QA (poudriere), in particular successfully testing switching CC ?
Comment 4 Sean Bruno freebsd_committer freebsd_triage 2015-11-09 15:40:58 UTC
Created attachment 162925 [details]
patch toolchain.m4 with support for non-default CC

Regenerate patch file with svn diff
Comment 5 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-09 21:59:31 UTC
Created attachment 164028 [details]
An alternate patch to Makefile

I think this patch is simpler and easier to maintain.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-12-14 23:03:20 UTC
A commit references this bug:

Author: jkim
Date: Mon Dec 14 23:02:50 UTC 2015
New revision: 403745
URL: https://svnweb.freebsd.org/changeset/ports/403745

Log:
  Respect CC, CPP and CXX with full paths.

  PR:		203747

Changes:
  head/java/openjdk8/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-12-14 23:06:22 UTC
A commit references this bug:

Author: jkim
Date: Mon Dec 14 23:05:49 UTC 2015
New revision: 403746
URL: https://svnweb.freebsd.org/changeset/ports/403746

Log:
  Respect CC, CPP and CXX with full paths.

  PR:		203747

Changes:
  head/java/openjdk8/Makefile
Comment 8 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-14 23:09:05 UTC
It should be fixed with r403745 and r403746.