Bug 203768
| Summary: | net-p2p/transmission-cli: Fix build failure with after net/miniupnpc update | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bernard Spil <brnrd> | ||||||||
| Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Many People | CC: | dinoex, jbeich | ||||||||
| Priority: | --- | Keywords: | easy, needs-qa, patch, regression | ||||||||
| Version: | Latest | Flags: | jbeich:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 203705 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 162035 [details]
svn diff for net-p2p/libtransmission-cli
Proper svn diff
Created attachment 162036 [details]
Poudriere build log net-p2p/transmission-cli
A commit references this bug: Author: jbeich Date: Wed Oct 14 14:57:00 UTC 2015 New revision: 399268 URL: https://svnweb.freebsd.org/changeset/ports/399268 Log: net-p2p/transmission-cli: chase r399209 https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9 PR: 203768 Reported by: many Obtained from: upstream MFH: 2015Q4 X-MFH-With: r399209 Changes: head/net-p2p/transmission-cli/Makefile head/net-p2p/transmission-cli/files/patch-libtransmission_upnp.c head/net-p2p/transmission-daemon/Makefile head/net-p2p/transmission-gtk/Makefile head/net-p2p/transmission-qt4/Makefile Thanks. Committed. Bugs fixing regressions usually block, rather than being blocked. Comment on attachment 162035 [details]
svn diff for net-p2p/libtransmission-cli
I've landed upstream fix which is slightly different. The patch here is fine except for bogus comment: TTL argument has nothing to do with the "security fix" which happened a few months later.
|
Created attachment 162034 [details] patch for miniupnpc issue After the update of miniupnpc transmission-daemon fails to build with an error in libtransmission/upnp.c This is caused by a change in the ABI of miniupnp. Attached patch fixes the build failure.