Bug 203768

Summary: net-p2p/transmission-cli: Fix build failure with after net/miniupnpc update
Product: Ports & Packages Reporter: Bernard Spil <brnrd>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Many People CC: dinoex, jbeich
Priority: --- Keywords: easy, needs-qa, patch, regression
Version: LatestFlags: jbeich: maintainer-feedback+
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 203705    
Attachments:
Description Flags
patch for miniupnpc issue
none
svn diff for net-p2p/libtransmission-cli
none
Poudriere build log net-p2p/transmission-cli none

Description Bernard Spil freebsd_committer 2015-10-14 12:55:28 UTC
Created attachment 162034 [details]
patch for miniupnpc issue

After the update of miniupnpc transmission-daemon fails to build with an error in libtransmission/upnp.c

This is caused by a change in the ABI of miniupnp.

Attached patch fixes the build failure.
Comment 1 Bernard Spil freebsd_committer 2015-10-14 12:56:09 UTC
Created attachment 162035 [details]
svn diff for net-p2p/libtransmission-cli

Proper svn diff
Comment 2 Bernard Spil freebsd_committer 2015-10-14 13:21:33 UTC
Created attachment 162036 [details]
Poudriere build log net-p2p/transmission-cli
Comment 3 commit-hook freebsd_committer 2015-10-14 14:58:00 UTC
A commit references this bug:

Author: jbeich
Date: Wed Oct 14 14:57:00 UTC 2015
New revision: 399268
URL: https://svnweb.freebsd.org/changeset/ports/399268

Log:
  net-p2p/transmission-cli: chase r399209

  https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9

  PR:		203768
  Reported by:	many
  Obtained from:	upstream
  MFH:		2015Q4
  X-MFH-With:	r399209

Changes:
  head/net-p2p/transmission-cli/Makefile
  head/net-p2p/transmission-cli/files/patch-libtransmission_upnp.c
  head/net-p2p/transmission-daemon/Makefile
  head/net-p2p/transmission-gtk/Makefile
  head/net-p2p/transmission-qt4/Makefile
Comment 4 Jan Beich freebsd_committer 2015-10-14 16:09:15 UTC
Thanks. Committed. Bugs fixing regressions usually block, rather than being blocked.
Comment 5 Jan Beich freebsd_committer 2015-10-14 16:17:24 UTC
Comment on attachment 162035 [details]
svn diff for net-p2p/libtransmission-cli

I've landed upstream fix which is slightly different. The patch here is fine except for bogus comment: TTL argument has nothing to do with the "security fix" which happened a few months later.