Bug 203769
| Summary: | [patch] databases/pgpool: Update to 3.4.3, Take MAINTAINER'ship | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Torsten Zühlsdorff <ports> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | Keywords: | patch, patch-ready | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 162039 [details]
poudriere log
> LIB_DEPENDS= libpq.so:${PORTSDIR}/databases/postgresql93-client Please use USES=pgsql instead > PORTDOCS= README AUTHORS COPYING ChangeLog INSTALL NEWS TODO Please do not install COPYING (handled by LICENSE, you could also add LICENSE_FILE), INSTALL (not needed as installation is done by the port) and README (empty apart from reference to doc/, which you probably should install) > %%ETCDIR%%.conf.sample This is incorrect usage of ETCDIR, as it does not really mean directory here. Better use plain etc/pgpool.conf.sample. Consider using @sample if default configs make any sense. > %%DATADIR%%-II/insert_lock.sql Better define DATADIR=${PREFIX}/share/${PORTNAME}-II and use %%DATADIR%%/ in plis > ${INSTALL_MAN} ${WRKSRC}/$f ${STAGEDIR}${DOCSDIR} This is incorrect, should use INSTALL_DATA. Hello Dmitry, i'm working on your suggestions. I've also stumbled over a bug in the pgsql Uses-Script which i'm currently fixing. I will update the patch when i am done. Thanks and Greetings, Torsten Created attachment 162283 [details]
path with update pgpool to 3.4.3 - version 2
Created attachment 162284 [details]
poudriere log for version 2
Hello Dmitry, i followed most of your suggestions. I did not get PORTDOCS to work as i want; i know this and will have a look later at it. Also %%ETCDIR%% confuses me, because this was generated by make makeplist. But it is rewritten now. Same for %%DATADIR%%. I also make one of the configurations files a sample and made it work. For this i also added a pkg-message, because two steps are needed before pgpool can start. Greetings, Torsten Committed with minor changes: - Use DATADIR - Install more docs - Add LICENSE_FILE A commit references this bug: Author: amdmi3 Date: Sun Nov 15 03:02:59 UTC 2015 New revision: 401653 URL: https://svnweb.freebsd.org/changeset/ports/401653 Log: - Update to 3.4.3 - Pass maintainership to submitter - Update MASTERSITE and www - Strip library PR: 203769 Submitted by: ports@toco-domains.de Changes: head/databases/pgpool/Makefile head/databases/pgpool/distinfo head/databases/pgpool/pkg-descr head/databases/pgpool/pkg-plist A commit references this bug: Author: amdmi3 Date: Sun Nov 15 03:04:15 UTC 2015 New revision: 401664 URL: https://svnweb.freebsd.org/changeset/ports/401664 Log: - Add forgotten pkg-message PR: 203769 Submitted by: ports@toco-domains.de Changes: head/databases/pgpool/pkg-message |
Created attachment 162038 [details] path with update pgpool to 3.4.3 I wrote a patch for databases/pgpool with the following changes: - update to 3.4.3 - become maintainer - change MASTERSITE - change homepage because project moved - honor stripping of new lib installed There are a number of similar ports for pgpool. I will have a look at them in the future.