Summary: | editors/sublime3: Cannot open files when path contains space | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Anthony Eadicicco <neffi> | ||||||
Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | miguelmclara | ||||||
Priority: | --- | Keywords: | easy, needs-qa, patch | ||||||
Version: | Latest | Flags: | miguelmclara:
maintainer-feedback+
koobs: merge-quarterly+ |
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204644 | ||||||||
Attachments: |
|
Description
Anthony Eadicicco
2015-10-15 00:45:29 UTC
Thanks for the report Anthony. Can you provide a patch again editors/sublime3 in unified diff (svn diff or diff -u) format please Also, should this change go upstream? Created attachment 162070 [details]
fix wrapper script; use "$@" instead of $*
Its not a upstream issue, Its my bad, when adding the shm check to the wrapper script I didn't even noticed that. But since files (or paths to files) can be passed as an argument it makes sense to use "$@" as you suggest. I'll attach a patch, but many thanks for catching this. @miguel, please set maintainer-approval (to +) on the patch you would like committed If you can manage QA results (portlint, poudriere) please also attach those. Created attachment 162207 [details]
fix wrapper script; use "$@" instead of $*
while on this also fix portlint warn (un-sorted USES)
portlin output now:
WARN: Makefile: [45]: possible use of "${CHMOD}" found. Use @(owner,group,mode) syntax or @owner/@group operators in pkg-plist instead.
WARN: Makefile: Consider defining LICENSE.
0 fatal errors and 2 warnings found.
A commit references this bug: Author: koobs Date: Tue Oct 20 04:25:45 UTC 2015 New revision: 399802 URL: https://svnweb.freebsd.org/changeset/ports/399802 Log: editors/sublime3: Fix opening filepaths with spaces Sublime 3 contains a wrapper script at /usr/local/bin/sublime to ensure that /dev/shm is set up correctly, and it's currently passing arguments to the real binary incorrectly. It currently causes sublime to incorrectly open any file where the path contains a space. - Modify sublime.in to open filepaths with spaces correctly - Bump PORTREVISION While I'm here: - Sort USES - Group USE{S} lines - Pet portlint (make patch `makepatch` compliant) PR: 203783 Submitted by: Miguel <miguelmclara gmail com> (maintainer) MFH: 2015Q4 Changes: head/editors/sublime3/Makefile head/editors/sublime3/files/patch-sublime_text.desktop head/editors/sublime3/files/sublime.in A commit references this bug: Author: koobs Date: Wed Oct 21 03:54:33 UTC 2015 New revision: 399886 URL: https://svnweb.freebsd.org/changeset/ports/399886 Log: MFH: r399802 editors/sublime3: Fix opening filepaths with spaces Sublime 3 contains a wrapper script at /usr/local/bin/sublime to ensure that /dev/shm is set up correctly, and it's currently passing arguments to the real binary incorrectly. It currently causes sublime to incorrectly open any file where the path contains a space. - Modify sublime.in to open filepaths with spaces correctly - Bump PORTREVISION While I'm here: - Sort USES - Group USE{S} lines - Pet portlint (make patch `makepatch` compliant) PR: 203783 Submitted by: Miguel <miguelmclara gmail com> (maintainer) Approved by: portmgr (bdrewery) Changes: _U branches/2015Q4/ branches/2015Q4/editors/sublime3/Makefile branches/2015Q4/editors/sublime3/files/patch-sublime_text.desktop branches/2015Q4/editors/sublime3/files/sublime.in Committed and MFH'd to quarterly branch, thank you Anthony, Miguel! I apologise this took so long. Please feel free to remind/bump/prod the project (within reason) until things get done, as sometimes things fall through the cracks. Small, easy, non-contentious, obvious things like this shouldn't. |