Bug 203849

Summary: security/bro: Update to 2.4.1, Add BROKER option
Product: Ports & Packages Reporter: Craig Leres <leres>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: leres: maintainer-feedback+
Hardware: Any   
OS: Any   
Bug Depends on: 203463, 203848    
Bug Blocks:    
Attachments:
Description Flags
patch
leres: maintainer-approval+
Poudriere log for 9.3-RELEASE-p28 and ports r399602
none
Poudriere log for 10.2-RELEASE and ports r399602 none

Description Craig Leres freebsd_committer freebsd_triage 2015-10-18 00:01:30 UTC
This PR updates security/bro from 2.3.2 to 2.4.1. It depends on:

    https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203463
        [PATCH] devel/caf: change PORTNAME to match ports directory name

    https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203848
         [PATCH] security/broccoli Switch to broccoli version number and update to 1.97

and should not be committed before they are.

Security fixes include:

    https://bro-tracker.atlassian.net/browse/BIT-1425
        BroString::Set() Attempts Allocation of Negative-Length
    
    https://bro-tracker.atlassian.net/browse/BIT-1459
        bro segfaults at analyzer::mime::MIME_Entity::ParseFieldParameters

Add a BROKER option which uses devel/caf (C++ actor framework). Note that bro 2.4.1 requires caf 0.13 so patches are included with this PR that upgrade bro to build with security/caf (0.14.1).

Remove obsolete ELASTICSEARCH option.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2015-10-18 00:01:53 UTC
Created attachment 162179 [details]
patch
Comment 2 Craig Leres freebsd_committer freebsd_triage 2015-10-18 00:06:03 UTC
Created attachment 162180 [details]
Poudriere log for 9.3-RELEASE-p28 and ports r399602

With BROKER enabled and edited so it doesn't exceed the attachment size limit
Comment 3 Craig Leres freebsd_committer freebsd_triage 2015-10-18 00:08:25 UTC
Created attachment 162181 [details]
Poudriere log for 10.2-RELEASE and ports r399602

With BROKER enabled and edited so it doesn't exceed the attachment size limit
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-10-23 19:05:28 UTC
A commit references this bug:

Author: riggs
Date: Fri Oct 23 19:04:52 UTC 2015
New revision: 400050
URL: https://svnweb.freebsd.org/changeset/ports/400050

Log:
  Update to upstream version 2.4.1, add BROKER OPTION

  PR:		203849
  Submitted by:	leres@ee.lbl.gov (maintainer)

Changes:
  head/security/bro/Makefile
  head/security/bro/distinfo
  head/security/bro/files/patch-aux-broker-CMakeLists.txt
  head/security/bro/files/patch-aux-broker-README
  head/security/bro/files/patch-aux-broker-src-address_type_info.hh
  head/security/bro/files/patch-aux-broker-src-data_type_info.hh
  head/security/bro/files/patch-aux-broker-src-endpoint_impl.hh
  head/security/bro/files/patch-aux-broker-src-peering_type_info.hh
  head/security/bro/files/patch-aux-broker-src-port_type_info.hh
  head/security/bro/files/patch-aux-broker-src-queue_impl.hh
  head/security/bro/files/patch-aux-broker-src-store-clone_impl.hh
  head/security/bro/files/patch-aux-broker-src-store-frontend.cc
  head/security/bro/files/patch-aux-broker-src-store-frontend_impl.hh
  head/security/bro/files/patch-aux-broker-src-store-master_impl.hh
  head/security/bro/files/patch-aux-broker-src-store-result_type_info.hh
  head/security/bro/files/patch-aux-broker-src-store-value_type_info.hh
  head/security/bro/files/patch-aux-broker-src-subnet_type_info.hh
  head/security/bro/files/patch-aux-broker-src-subscription.hh
  head/security/bro/files/patch-aux-broker-src-util-queue_actor.hh
  head/security/bro/pkg-plist
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2015-10-23 19:06:35 UTC
Committed with minor changes: Fixed pkg-plist when BROKER and BROCCOLI OPTIONs are deselected.