Summary: | graphics/zathura-pdf-mupdf: Add missing LIB_DEPENDS | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | claudius <ccs189> | ||||
Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | koobs, uzsolt | ||||
Priority: | --- | Keywords: | easy, patch, patch-ready | ||||
Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||
Hardware: | amd64 | ||||||
OS: | Any | ||||||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203866 | ||||||
Attachments: |
|
Description
claudius
2015-10-18 04:56:16 UTC
(In reply to claudius from comment #0) $ ldd /usr/local/lib/zathura/pdf.so | grep jpeg libjpeg.so.8 => /usr/local/lib/libjpeg.so.8 (0x805006000) $ pkg which /usr/local/lib/libjpeg.so.8 /usr/local/lib/libjpeg.so.8 was installed by package jpeg-turbo-1.4.2 $ pkg delete --dry-run jpeg-turbo | sed -n "1,4p ; /zathura/p" Checking integrity... done (0 conflicting) Deinstallation has been requested for the following 92 packages (of 0 packages in the universe): Installed packages to be REMOVED: zathura-0.3.3 zathura-pdf-mupdf-0.2.7_3 It seems for me it's okay. Ooops, sorry. $ ldd /usr/local/lib/zathura/pdf.so | grep openjp libopenjp2.so.7 => /usr/local/lib/libopenjp2.so.7 (0x804dce000) $ pkg which /usr/local/lib/libopenjp2.so.7 /usr/local/lib/libopenjp2.so.7 was installed by package openjpeg-2.1.0_1 $ pkg delete --dry-run openjpeg | sed -n "1,4p ; /zathura/p" Checking integrity... done (0 conflicting) Deinstallation has been requested for the following 9 packages (of 0 packages in the universe): Installed packages to be REMOVED: It seems it's bug in package. I'll check it soon. I checked. Poudriere log: http://poudriere.uzsolt.hu/amd64-default/2015-10-19_19h09m38s/logs/zathura-pdf-mupdf-0.2.7_3.log The openjpeg and jbig2dec will install as dependencies of mupdf which is only build-dependency of zathura-pdf-mupdf. I think should add jbig2dec and openjpeg as LIB_DEPENDS. Patch added. Created attachment 162214 [details]
patch
@Zsolt, can you confirm this passes QA (portlint, poudriere) please Poudriere log: http://poudriere.uzsolt.hu/amd64-default/2015-10-20_06h50m10s/logs/zathura-pdf-mupdf-0.2.7_3.log Sorry, the log before is simple "build", this is the "testport" log: http://poudriere.uzsolt.hu/latest-per-pkg/zathura-pdf-mupdf/0.2.7_3/amd64-default.log Perfect, thank you! :) A commit references this bug: Author: koobs Date: Tue Oct 20 08:11:54 UTC 2015 New revision: 399805 URL: https://svnweb.freebsd.org/changeset/ports/399805 Log: graphics/zathura-pdf-mupdf: Add missing LIB_DEPENDS Add missing jbig2dec and openjpeg to LIB_DEPENDS, registering them as run-time dependencies. Without this change, both packages are removed during pkg autoremove, resulting in the inability to open PDF files. PR: 203850 Submitted by: Zsolt Udvari <udvzsolt gmail com> (maintainer) MFH: 2015Q4 Changes: head/graphics/zathura-pdf-mupdf/Makefile @Zsolt, can you provide the full ldd output of zathura (as an attachment) please A commit references this bug: Author: koobs Date: Wed Oct 21 03:56:38 UTC 2015 New revision: 399887 URL: https://svnweb.freebsd.org/changeset/ports/399887 Log: MFH: r399805 graphics/zathura-pdf-mupdf: Add missing LIB_DEPENDS Add missing jbig2dec and openjpeg to LIB_DEPENDS, registering them as run-time dependencies. Without this change, both packages are removed during pkg autoremove, resulting in the inability to open PDF files. PR: 203850 Submitted by: Zsolt Udvari <udvzsolt gmail com> (maintainer) Approved by: portmgr (bdrewery) Changes: _U branches/2015Q4/ branches/2015Q4/graphics/zathura-pdf-mupdf/Makefile @Zsolt Ignore my request in comment 10, I found the information I needed at your poudriere server Committed and MFH'd to quarterly branch, thank you Zsolt / Claudius! |