Bug 203869

Summary:

security/bruteblock patch to use devel/iniparser lib from ports tree and clean build warnings

Product:

Ports & Packages

Reporter:

Denys Razumov <zxzharmlesszxz>

Component:

Individual Port(s)

Assignee:

Dmitry Marakasov <amdmi3>

Status:

Closed Not Accepted

Severity:

Affects Only Me

CC:

amdmi3, kevlo, miwi

Priority:

---

Keywords:

needs-qa, patch

Version:

Latest

Flags:

koobs: maintainer-feedback? (amdmi3)

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Patch file to switch use lib iniparser from ports tree and clran build warnings	koobs: maintainer-approval? (amdmi3)
Patch file to switch use lib iniparser from ports tree, libutil(pidfile.h) from base and clean build warnings	none
Patch file to switch use lib iniparser from ports tree, libutil(pidfile.h) from base and clean build warnings(fixed EOF)	none

Description Denys Razumov 2015-10-19 10:28:09 UTC

Created attachment 162202 [details]
Patch file to switch use lib iniparser from ports tree and clran build warnings

Comment 1 Denys Razumov 2015-10-19 11:28:35 UTC

old
# make

===>  Found saved configuration for bruteblock-0.0.5_9
===>   bruteblock-0.0.5_9 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by bruteblock-0.0.5_9 for building
===>  Extracting for bruteblock-0.0.5_9
=> SHA256 Checksum OK for bruteblock-0.0.5.tar.gz.
===>  Patching for bruteblock-0.0.5_9
===>  Applying FreeBSD patches for bruteblock-0.0.5_9
===>   bruteblock-0.0.5_9 depends on shared library: libpcre.so - found (/usr/local/lib/libpcre.so)
===>  Configuring for bruteblock-0.0.5_9
===>  Building for bruteblock-0.0.5_9
--- bruteblock.o ---
--- utils.o ---
--- bruteblock.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -s -Wall -I/usr/local/include -c bruteblock.c
--- utils.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -s -Wall -I/usr/local/include -c utils.c
cc: warning: argument unused during compilation: '-s'
--- bruteblock.o ---
cc: warning: argument unused during compilation: '-s'
bruteblock.c:133:4: warning: format specifies type 'int' but the argument has type 'time_t' (aka 'long') [-Wformat]
                        hosts_table[i].access_time);
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
bruteblock.c:232:12: warning: passing 'unsigned char *' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                snprintf(buffer, BUFFER_SIZE, ":regexp%d", i);
                         ^~~~~~
/usr/include/stdio.h:279:32: note: passing argument to parameter here
int      snprintf(char * __restrict, size_t, const char * __restrict,
                                   ^
bruteblock.c:233:34: warning: passing 'unsigned char *' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                regexp = iniparser_getstr(ini, buffer);
                                               ^~~~~~
./iniparse/iniparser.h:126:48: note: passing argument to parameter 'key' here
char * iniparser_getstr(dictionary * d, char * key);
                                               ^
bruteblock.c:258:11: warning: passing 'unsigned char *' to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                        strlen(buffer), /* the length of the subject */
                               ^~~~~~
/usr/include/string.h:95:28: note: passing argument to parameter here
size_t   strlen(const char *) __pure;
                            ^
bruteblock.c:257:4: warning: passing 'unsigned char *' to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                        buffer, /* the subject string */
                        ^~~~~~
/usr/local/include/pcre.h:573:73: note: passing argument to parameter here
PCRE_EXP_DECL int  pcre_exec(const pcre *, const pcre_extra *, PCRE_SPTR,
                                                                        ^
bruteblock.c:278:11: warning: initializing 'char *' with an expression of type 'unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                                char *substring_start = buffer + ovector[2*i];
                                      ^                 ~~~~~~~~~~~~~~~~~~~~~
--- ipfw2.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -s -Wall -I/usr/local/include -c ipfw2.c
cc: warning: argument unused during compilation: '-s'
--- bruteblock.o ---
6 warnings generated.
--- iniparse/libiniparser.a ---
--- iniparser.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -c iniparser.c
--- dictionary.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -c dictionary.c
--- bruteblockd.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -s -Wall -I/usr/local/include -c bruteblockd.c
cc: warning: argument unused during compilation: '-s'
--- iniparse/libiniparser.a ---
--- strlib.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -c strlib.c
--- pidfile.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -s -Wall -I/usr/local/include -c pidfile.c
cc: warning: argument unused during compilation: '-s'
--- iniparse/libiniparser.a ---
--- libiniparser.a ---
--- bruteblock ---
--- bruteblockd ---
--- bruteblock ---
cc  -fstack-protector -s -o bruteblock bruteblock.o utils.o ipfw2.o -L/usr/local/lib -Liniparse -lpcre -liniparser
--- bruteblockd ---
cc  -fstack-protector -s -o bruteblockd bruteblockd.o utils.o ipfw2.o pidfile.o -L/usr/local/lib -Liniparse -lpcre -liniparser
===>  Staging for bruteblock-0.0.5_9
===>   Generating temporary packing list
install  -s -m 555 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/bruteblock /usr/ports/security/bruteblock/work/stage/usr/local/sbin/
install  -s -m 555 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/bruteblockd /usr/ports/security/bruteblock/work/stage/usr/local/sbin/
/bin/mkdir -p /usr/ports/security/bruteblock/work/stage/usr/local/etc/bruteblock
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/etc/ssh.conf /usr/ports/security/bruteblock/work/stage/usr/local/etc/bruteblock/ssh.conf.sample
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/etc/proftpd.conf /usr/ports/security/bruteblock/work/stage/usr/local/etc/bruteblock/proftpd.conf.sample
install  -m 444 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/bruteblock.8 /usr/ports/security/bruteblock/work/stage/usr/local/man/man8/
/bin/mkdir -p /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/FAQ /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock/
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/README /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock/
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/CHANGES /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock/
====> Compressing man pages (compress-man)
===> Staging rc.d startup script(s)


new
# make
===>  Found saved configuration for bruteblock-0.0.5_9
===>   bruteblock-0.0.5_9 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by bruteblock-0.0.5_9 for building
===>  Extracting for bruteblock-0.0.5_9
=> SHA256 Checksum OK for bruteblock-0.0.5.tar.gz.
===>  Patching for bruteblock-0.0.5_9
===>  Applying FreeBSD patches for bruteblock-0.0.5_9
===>   bruteblock-0.0.5_9 depends on shared library: libpcre.so - found (/usr/local/lib/libpcre.so)
===>   bruteblock-0.0.5_9 depends on shared library: libiniparser.so - found (/usr/local/lib/libiniparser.so)
===>  Configuring for bruteblock-0.0.5_9
===>  Building for bruteblock-0.0.5_9
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -Wall -I/usr/local/include -c bruteblock.c
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -Wall -I/usr/local/include -c utils.c
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -Wall -I/usr/local/include -c ipfw2.c
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -Wall -I/usr/local/include -c bruteblockd.c
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -Wall -I/usr/local/include -c pidfile.c
cc  -fstack-protector -s -o bruteblock bruteblock.o utils.o ipfw2.o -L/usr/local/lib -lpcre -liniparser
cc  -fstack-protector -s -o bruteblockd bruteblockd.o utils.o ipfw2.o pidfile.o -L/usr/local/lib -lpcre -liniparser
===>  Staging for bruteblock-0.0.5_9
===>   Generating temporary packing list
install  -s -m 555 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/bruteblock /usr/ports/security/bruteblock/work/stage/usr/local/sbin/
install  -s -m 555 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/bruteblockd /usr/ports/security/bruteblock/work/stage/usr/local/sbin/
/bin/mkdir -p /usr/ports/security/bruteblock/work/stage/usr/local/etc/bruteblock
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/etc/ssh.conf /usr/ports/security/bruteblock/work/stage/usr/local/etc/bruteblock/ssh.conf.sample
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/etc/proftpd.conf /usr/ports/security/bruteblock/work/stage/usr/local/etc/bruteblock/proftpd.conf.sample
install  -m 444 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/bruteblock.8 /usr/ports/security/bruteblock/work/stage/usr/local/man/man8/
/bin/mkdir -p /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/FAQ /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock/
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/README /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock/
install  -m 0644 /usr/ports/security/bruteblock/work/bruteblock-0.0.5/doc/CHANGES /usr/ports/security/bruteblock/work/stage/usr/local/share/doc/bruteblock/
====> Compressing man pages (compress-man)
===> Staging rc.d startup script(s)

Comment 2 Kubilay Kocak freebsd_committer

2015-10-19 11:32:01 UTC

Please use attachments for log output in future

Comment 3 Denys Razumov 2015-10-21 12:35:14 UTC

Created attachment 162282 [details]
Patch file to switch use lib iniparser from ports tree, libutil(pidfile.h) from base and clean build warnings

If maitainer doesn't fix, I attach new patch

Comment 4 Dmitry Marakasov freebsd_committer

2015-10-21 13:12:20 UTC

The patch doesn'y apply. Please fix CRLF line endings

Comment 5 Denys Razumov 2015-10-22 16:15:36 UTC

Created attachment 162362 [details]
Patch file to switch use lib iniparser from ports tree, libutil(pidfile.h) from base and clean build warnings(fixed EOF)

 Patch file to switch use lib iniparser from ports tree, libutil(pidfile.h) from base and clean build warnings(fixed EOF)

My next patch will be a move to use ipfw2 headers and src from the systems if necessary

Comment 6 Martin Wilke freebsd_committer

2016-01-18 06:38:01 UTC

Hi,

Any progress here?

Comment 7 Denys Razumov 2016-01-27 19:34:47 UTC

I add patch already. Maintainer don't give answer. I add new patch tomorrow.

Comment 8 Dmitry Marakasov freebsd_committer

2016-01-29 15:29:27 UTC

What is the purpose of this patch apart from fixing warnings?

Comment 9 Denys Razumov 2016-01-30 14:48:07 UTC

Using the libraries libiniparser- from /usr/ports/devel/iniparser and sources pidfile.h, utils.h - from /usr/src/lib/libutil, ipfw2.h - from /usr/src/sbin/ipfw.

Comment 10 Dmitry Marakasov freebsd_committer

2016-01-30 21:49:08 UTC

Again, what's the purpose?

Comment 11 Denys Razumov 2016-01-30 23:57:45 UTC

Purpose of my patch is a using in all software libraries and sources from ports tree and base-system

Comment 12 Dmitry Marakasov freebsd_committer

2016-02-01 14:32:01 UTC

That's the method, not the purpose. I do not understand what good this change does, while it increases maintenance burden by adding extra patches.

Comment 13 Dmitry Marakasov freebsd_committer

2016-02-19 14:50:49 UTC

In the end, I don't see any profit from this change.