Bug 203872
| Summary: | [NEW PORT] chinese/gydict: Command line tool of Yahoo! Dictionary | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sean Chang <chihhsin> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Martin Wilke <miwi> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | koobs, miwi, python | ||||||||||||
| Priority: | --- | Keywords: | feature, patch, patch-ready | ||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
@Sean, on initial review: * Use USES=python:[run,<version>] to declare a dependency on Python. See /usr/ports/Mk/Uses/python.mk for more details * You may want to consider a more specific primary category than 'chinese'. Something like <category> chinese python. Is the ports functionality for instance limited to the Chinese version of the Yahoo! dictionary? * GH_PROJECT defaults to PORTNAME, and is unnecessary * PLIST_FILES value shouldnt need a PREFIX Please also run this port through QA (portlint, poudriere) to ensure it passes, fixing any reported issues, and then update the attachment here. Created attachment 162224 [details]
shell archive of gydict (updated)
- Fix the dependency on Python
- Remove GH_PROJECT
- PLIST_FILES without PREFIX
(In reply to Kubilay Kocak from comment #1) The functionality of the port is actually limited in Chinese to English and English to Chinese translation. And it parses the contents from Chinese version of Yahoo! Dictionary. So I believe put it in chinese category is appropriate. This is my first time submitting a port. I'll do my best. Thank you for your comments. Created attachment 162225 [details]
portlint output of gydict
Created attachment 162226 [details]
poudriere testport of gydict
@Sean, thanks for the update, though I would still recommend adding textproc and python as secondary categories. Created attachment 162228 [details]
shell archive of gydict (with secondary categories)
Sorry for my ignorance, is there something I should do for this port to be committed now? I'm not familiar with the workflow after the flag (maintainer-approval+) set up. @Sean, nothing else needed from your side that I can see :) A commit references this bug: Author: miwi Date: Mon Jan 4 09:04:29 UTC 2016 New revision: 405224 URL: https://svnweb.freebsd.org/changeset/ports/405224 Log: A command line tool to do EN <-> CH translation, utilized by Yahoo! Dictionary. WWW: https://github.com/iamgyz/gydict PR: 203872 Submitted by: Chih-Hsin Chang <chihhsin@cs.nctu.edu.tw> Changes: head/chinese/Makefile head/chinese/gydict/ head/chinese/gydict/Makefile head/chinese/gydict/distinfo head/chinese/gydict/pkg-descr |
Created attachment 162209 [details] shell archive of gydict Re-implement deprecated chinese/ydict with Python3.