Bug 203876

Summary: "pw groupnext" does not output anything
Product: Base System Reporter: Florian Degner <f.degner>
Component: binAssignee: Enji Cooper <ngie>
Status: Closed FIXED    
Severity: Affects Only Me CC: bapt, ngie
Priority: --- Flags: ngie: mfc-stable10+
ngie: mfc-stable9-
ngie: mfc-stable8-
Version: 10.2-STABLE   
Hardware: Any   
OS: Any   

Description Florian Degner 2015-10-19 18:22:57 UTC
Running "pw groupnext" does not output anything:

$ pw groupnext
$ echo $?
159
$

This is because the variable "quiet" in pw_group_next() is used uninitialized [1].


[1] https://svnweb.freebsd.org/base/stable/10/usr.sbin/pw/pw_group.c?revision=287084&view=markup#l255
Comment 1 Enji Cooper freebsd_committer freebsd_triage 2015-10-19 18:24:31 UTC
Yeah...
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-10-19 18:29:38 UTC
A commit references this bug:

Author: ngie
Date: Mon Oct 19 18:29:33 UTC 2015
New revision: 289600
URL: https://svnweb.freebsd.org/changeset/base/289600

Log:
  Initialize `quiet` to false so `pw groupnext` again prints out the next gid
  by default

  Reported by: Florian Degner <f.degner@gmx.de>
  MFC after: 1 week
  PR: 203876
  Sponsored by: EMC / Isilon Storage Division

Changes:
  head/usr.sbin/pw/pw_group.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-10-26 00:28:55 UTC
A commit references this bug:

Author: ngie
Date: Mon Oct 26 00:28:06 UTC 2015
New revision: 289978
URL: https://svnweb.freebsd.org/changeset/base/289978

Log:
  MFC r289600:

  Initialize `quiet` to false so `pw groupnext` again prints out the next gid
  by default

  Reported by: Florian Degner <f.degner@gmx.de>
  PR: 203876
  Sponsored by: EMC / Isilon Storage Division

Changes:
_U  stable/10/
  stable/10/usr.sbin/pw/pw_group.c
Comment 4 Enji Cooper freebsd_committer freebsd_triage 2015-10-26 00:31:20 UTC
bapt didn't MFC r287084 to stable/9. Closing.