Bug 203972
| Summary: | [patch] net/uriparser: Update to 0.8.4 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Torsten Zühlsdorff <ports> | ||||||
| Component: | Individual Port(s) | Assignee: | Ed Schouten <ed> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | Keywords: | patch | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(ed) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 203949 | ||||||||
| Attachments: |
|
||||||||
Created attachment 162378 [details]
poudriere log
Hi Torsten, Thanks for the patch! I just took a look at it. I can also reproduce the build failure. Looking at the compiler error, I think we can simplify the patch slightly. We only need to #include <sys/socket.h> to get AF_INET/AF_INET6. I just sent out a code review to bapt@, as I typically run patches past him. https://reviews.freebsd.org/D4001 A commit references this bug: Author: ed Date: Tue Oct 27 07:33:47 UTC 2015 New revision: 400218 URL: https://svnweb.freebsd.org/changeset/ports/400218 Log: Update uriparser to version 0.8.4. It looks like the latest release doesn't build because of a missing #include. The source file depends on AF_INET and AF_INET6, which of course requires <sys/socket.h>. Submitted by: Torsten Z?hlsdorff PR: 203972 Differential Revision: https://reviews.freebsd.org/D4001 Changes: head/net/uriparser/Makefile head/net/uriparser/distinfo head/net/uriparser/files/ head/net/uriparser/files/patch-tool_uriparse.c head/net/uriparser/pkg-plist Committed as r400218. Thanks! |
Created attachment 162377 [details] Patch with update to version 0.8.4 Hello, attached a patch to bump the library to the newest version. While there i defined the License too. Attention: i needed to create a patch in order to make the port compiling. But my C experience is quite old, therefore please have a closer look at what i had done :D As side-result portlint is now happy: # portlint -C looks fine. Greetings, Torsten