Bug 203981
| Summary: | [patch] lang/nim: Update to 0.11.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Torsten Zühlsdorff <ports> | ||||||
| Component: | Individual Port(s) | Assignee: | Mathieu Arnold <mat> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | ports | ||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||
| Version: | Latest | Flags: | ports:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200935 | ||||||||
| Attachments: |
|
||||||||
Created attachment 162392 [details]
poudriere log
Add dependency to 200935 even if the PRs are just related to another. Dependency provides an old patch, which is similar to mine. My patch does the some but also respects the new qa-standards of portlint. This patch seems OK, supplanting my old one which langushed for some time in the database. I don't see the reason for the change in the comment however. It is "The" Nim language after all. The article is required in English. Other than that, all is good. (In reply to Neal Nelson from comment #3) > I don't see the reason for the change in the comment however. > It is "The" Nim language after all. The article is required in English. The change was done to pet portlint. Thats the only reason for the rework and could be undone. Should i undone it? If you are fine with the patch please set the maintainer-flag. If you want me do change the comment back please set the feedback to "-" and i will update the patch. :) Greetings, Torsten The <title> of the nim-lang.org homeage is "Nim Programming Language" and is consistent with COMMENT standards of not using a leading indefinite article. In this case the modified COMMENT is valid (and is substantiated by upstream language). @Torsten, please use See Also for issues that refer to this or are related to other issues. Depends/Blocks is exactly and only for when listed issues MUST be resolved prior to, or after this one, respectively. Comment on attachment 162391 [details]
patch with update to 0.11.2
Maintainer approved in commetn 3, with committer follow up to confirm COMMENT change. This patch is good to go.
A commit references this bug: Author: mat Date: Wed Oct 28 12:57:47 UTC 2015 New revision: 400388 URL: https://svnweb.freebsd.org/changeset/ports/400388 Log: Update to 0.11.2 PR: 203981 Submitted by: Torsten Z?hlsdorff Approved by: maintainer Sponsored by: Absolight Changes: head/lang/nim/Makefile head/lang/nim/distinfo head/lang/nim/pkg-plist |
Created attachment 162391 [details] patch with update to 0.11.2 Hello, attached a patch to update the port to the current version 0.11.2. While there: - recreate patches with make makepatch - remove PORTREVISION=0 - rework the COMMENT a little -> short: make portlint happy Greetings, Torsten