Summary: | [patch] games/0ad 0.0.18_1 build failure due to invalid number of argument for upnpDiscover function | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Thibault Payet <monwarez> | ||||
Component: | Individual Port(s) | Assignee: | Guido Falsi <madpilot> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | Keywords: | patch | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(madpilot) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Hi, thanks for reporting this. I'll test your patch, since this is a biggish port, please allow me for time for this. I'll also try to discover what triggered this, since it was not happening a few weeks ago! I'll keep you updated. Hi again, already found the cause. The net/miniupnp port was updated and it contains an API change. While your patch isn't wrong I'll import the change from the upstream repository which addresses this same problem: http://trac.wildfiregames.com/changeset/17091/ps/trunk/source/network/NetServer.cpp Comment on attachment 162394 [details]
Patch to fix it (not the best solution I think)
Will use changeset from upstream repository.
A commit references this bug: Author: madpilot Date: Sat Oct 24 07:12:14 UTC 2015 New revision: 400109 URL: https://svnweb.freebsd.org/changeset/ports/400109 Log: Import change from upstream to fix build after net/miniupnp update. [1] While here also mark BROKEN on 9.x, due to gcc crashing during the build. PR: 203983 [1] Submitted by: monwarez at mailoo.org Changes: head/games/0ad/Makefile head/games/0ad/files/patch-source_network_NetServer.cpp Fix committed. Thanks again for reporting the issue. |
Created attachment 162394 [details] Patch to fix it (not the best solution I think) When I attempt to build 0ad from port , I get an error about invalid number of argument in the function upnpDiscover. So I made a patch to get this compiled.