Bug 204054
| Summary: | www/libevhtp: upgrade to 1.2.10 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Edward Tomasz Napierala <trasz> | ||||||
| Component: | Individual Port(s) | Assignee: | Jason Unovitch <junovitch> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | Ultima1252, junovitch, yan_jingfeng | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(Ultima1252) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | 204106 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
www/libevhtp has a new maintainer as the original maintainer has a new family member to keep their hands full. Assign to new maintainer for feedback. Hello Edward, thanks for submitting a patch. Could you please explain the the change to file evhtp.h, why it needs EVHTP_EXPORT? Without it, the symbol wouldn't get exported. Basically you would get a link error without it. Same change was committed to the upstream, see https://github.com/ellzey/libevhtp/commit/c2168be8dff307ebc7aeea47bc79f7a615bd2da5. Created attachment 162578 [details]
libevhtp.diff
Patch looks good to me. I'm adding a couple more things to make portlint and poudriere happy with a couple options.
* Update to 1.2.10
* include/onigposix.h to PLIST only when option EVHTP_DISABLE_REGEX not selected
* include/evthr.h only when option EVHTP_DISABLE_EVTHR not selected
* Recreated patch files for portlint
Thanks again Edward =]
A commit references this bug: Author: junovitch Date: Fri Oct 30 02:25:41 UTC 2015 New revision: 400488 URL: https://svnweb.freebsd.org/changeset/ports/400488 Log: www/libevhtp: update 1.2.9 -> 1.2.10 and assorted fixes - Update PORTVERSION, GH_TAGNAME, and distinfo for 1.2.10 - include/onigposix.h in PLIST when EVHTP_DISABLE_REGEX is not selected - include/evthr.h when option EVHTP_DISABLE_EVTHR is not selected - Add patch to ensure symbol gets exported from evhtp.h - Recreated patch files for portlint PR: 204054 Submitted by: trasz (original patch, multiple changes from maintainer) Approved by: Ricky Gallamore <ultima1252@gmail.com> (maintainer) Changes: head/www/libevhtp/Makefile head/www/libevhtp/distinfo head/www/libevhtp/files/patch-evhtp.c head/www/libevhtp/files/patch-evhtp.h Committed. Thanks! Add depends on bug 204106 to have the audit trail on why the maintainer-feedback was fixed. See also: https://lists.FreeBSD.org/pipermail/freebsd-ports/2015-October/100923.html |
Created attachment 162494 [details] patch Attached patch updates the port to 1.2.10. Not tested with poudriere, though.